Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 28, 2019

No description provided.

@rullzer rullzer added the 2. developing Work in progress label Nov 28, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Nov 28, 2019
@skjnldsv skjnldsv force-pushed the enh/gs/always_search_lookup branch from e8becfd to 6c27b5a Compare December 3, 2019 09:58
@skjnldsv
Copy link
Member

skjnldsv commented Dec 3, 2019

@rullzer I did the front, but there is one thing that was used that is not compliant to your new config:


$this->result['lookupEnabled'] = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'yes') === 'yes';

@rullzer
Copy link
Member Author

rullzer commented Dec 3, 2019

@rullzer I did the front, but there is one thing that was used that is not compliant to your new config:

$this->result['lookupEnabled'] = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'yes') === 'yes';

right. Let me fix that. Thanks for the work.

@rullzer rullzer added 3. to review Waiting for reviews bug and removed 2. developing Work in progress labels Dec 3, 2019
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skjnldsv skjnldsv force-pushed the enh/gs/always_search_lookup branch from ff21cdd to 49f4e3d Compare December 5, 2019 06:55
@skjnldsv
Copy link
Member

skjnldsv commented Dec 5, 2019

Rebased

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 5, 2019

@rullzer one more test to make sure everything is how you wanted?

rullzer and others added 3 commits December 5, 2019 08:38
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer rullzer force-pushed the enh/gs/always_search_lookup branch from 49f4e3d to 9b82225 Compare December 5, 2019 07:38
@rullzer
Copy link
Member Author

rullzer commented Dec 5, 2019

Fixed the tests.

@skjnldsv it does what it should do it hink. What I find weird is that when you press search globally that the dropdown vanishes and you don't get proper feedback 'no results found' or something. But lets get this in and fix that later..

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rullzer rullzer merged commit 6f540fc into master Dec 5, 2019
@rullzer rullzer deleted the enh/gs/always_search_lookup branch December 5, 2019 08:47
@rullzer
Copy link
Member Author

rullzer commented Dec 5, 2019

We should backport the functinality to 17 and 16 (maybe even 15) but will require manual work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants