Skip to content

Conversation

@Noodlesalat
Copy link
Member

This reverts #16366 and fixes #17891

Result:
padding-filelist

Signed-off-by: Fabian Dreßler nudelsalat@clouz.de

@Noodlesalat Noodlesalat force-pushed the fix-padding-top-filelist branch from 49f921f to 0b2e32f Compare November 18, 2019 16:35
This reverts nextcloud#16366 and fixes nextcloud#17891

Signed-off-by: Fabian Dreßler <nudelsalat@clouz.de>
@Noodlesalat Noodlesalat force-pushed the fix-padding-top-filelist branch from 0b2e32f to 8261e74 Compare November 18, 2019 16:35
@kesselb kesselb requested review from GretaD and skjnldsv November 18, 2019 19:48
@kesselb kesselb added 3. to review Waiting for reviews bug labels Nov 18, 2019
@kesselb kesselb added this to the Nextcloud 18 milestone Nov 18, 2019
@skjnldsv skjnldsv added the design Design, UI, UX, etc. label Nov 18, 2019
@jancborchardt
Copy link
Member

@Noodlesalat nice! Does this still fix the original issue which was intended to be fixed by the reverted pull request?

@Gatak could you review this pull request as it fixes the issue you reported at #17891 :)

@Noodlesalat
Copy link
Member Author

I wasn't able to reproduce the mentioned original issue with my development instance. :)

@jancborchardt
Copy link
Member

@GretaD can you check, since it reverts a pull request of yours?

@GretaD
Copy link
Contributor

GretaD commented Nov 21, 2019

@GretaD can you check, since it reverts a pull request of yours?

sure, its on my "this week" list.

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like it should, the first row its shown correctly and the space is smaller. Very good @Noodlesalat :)

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Nov 30, 2019
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first change made to the AUTHORS file in 2 years. Is that made by a script or added by authors?

@jancborchardt
Copy link
Member

This is the first change made to the AUTHORS file in 2 years. Is that made by a script or added by authors?

Good question, also regarding the copyright header – which would basically have a lot more people but in practice we don’t do that with every pull request (especially not 2 line ones like this).

cc @rullzer @schiessle can you provide input?

@rullzer rullzer merged commit 90401e5 into nextcloud:master Dec 5, 2019
@welcome
Copy link

welcome bot commented Dec 5, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

...

7 participants