Fix files_sharing app LoadSidebar event #17821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
ChristophWurst,
georgehrke,
icewind1991,
juliusknorr and
rullzer
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
c056730 to
a1dbd95
Compare
kesselb
reviewed
Nov 5, 2019
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
a1dbd95 to
8740a64
Compare
|
All fixed! Please review! :) |
ChristophWurst
approved these changes
Nov 6, 2019
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
8740a64 to
2ab558c
Compare
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
2ab558c to
57694dd
Compare
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
57694dd to
72a6fd0
Compare
ChristophWurst
approved these changes
Nov 8, 2019
14 tasks
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
2 times, most recently
from
75be168 to
59aee2f
Compare
This comment has been minimized.
This comment has been minimized.
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
5 times, most recently
from
10507be to
849f43f
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
849f43f to
a09203e
Compare
This comment has been minimized.
This comment has been minimized.
npmbuildbot-nextcloud
bot
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
a09203e to
55c1ead
Compare
This comment has been minimized.
This comment has been minimized.
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
55c1ead to
a571192
Compare
npmbuildbot-nextcloud
bot
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
a571192 to
b7aebb5
Compare
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
2 times, most recently
from
5e8cc6e to
49c30fe
Compare
|
Hopefully lasts fixes for tests to pass! 😭 |
skjnldsv
force-pushed
the
feat/loadsidebar/files_sharing
branch
from
49c30fe to
5cb11ca
Compare
|
Tests passed 🚀 |
rullzer
approved these changes
Dec 2, 2019
MorrisJobke
reviewed
Oct 29, 2020
|
|
||
| public function register(): void { | ||
| $dispatcher = $this->getContainer()->getServer()->getEventDispatcher(); | ||
| protected function registerEventsScripts(IEventDispatcher $dispatcher) { |
There was a problem hiding this comment.
This is where we broke the dispatch of addListener in line 214, where GenericEvent is type hinted in the callback, right @rullzer? That's what Psalm found in https://github.com/nextcloud/server/pull/23742/files#diff-f24715432b9a8ad98f1ff9c441096d8afd1ed1bcfb43f04a04ad2894e050e2a8R156
Nice catch by psalm I would say - cc @ChristophWurst @kesselb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com