Skip to content

Conversation

@tcoupin
Copy link
Member

@tcoupin tcoupin commented Oct 29, 2019

See nextcloud/circles#346

Reshare with circle does not work. This PR fix this.

Signed-off-by: Thibault Coupin <thibault.coupin@gmail.com>
@tcoupin
Copy link
Member Author

tcoupin commented Oct 31, 2019

This PR is very important for my work installation since we use "circle quota" (technical account who shares root with circles of local admin, with reshare permission). Today, local admin can not share a folder shared by the technical account. It's very blocking...

Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my! The CI tests actually all passed for once! This should not be something unusual...

@ChristophWurst ChristophWurst merged commit a767a2f into nextcloud:master Nov 4, 2019
@welcome
Copy link

welcome bot commented Nov 4, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@tcoupin tcoupin deleted the fix-reshare-circle branch November 5, 2019 08:34
@tcoupin
Copy link
Member Author

tcoupin commented Nov 12, 2019

Will this PR be released in version 17.x ?

@ChristophWurst
Copy link
Member

/backport to stable17

@backportbot-nextcloud
Copy link

backport to stable17 in #17916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants