- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4.6k
Fix reshare with circle #17735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reshare with circle #17735
Conversation
Signed-off-by: Thibault Coupin <thibault.coupin@gmail.com>
| This PR is very important for my work installation since we use "circle quota" (technical account who shares root with circles of local admin, with reshare permission). Today, local admin can not share a folder shared by the technical account. It's very blocking... | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my! The CI tests actually all passed for once! This should not be something unusual...
| Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 | 
| Will this PR be released in version 17.x ? | 
| /backport to stable17 | 
| backport to stable17 in #17916 | 
See nextcloud/circles#346
Reshare with circle does not work. This PR fix this.