Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 28, 2019

@rullzer rullzer added 2. developing Work in progress overview labels Oct 28, 2019
@rullzer rullzer added this to the Nextcloud 15.0.13 milestone Oct 28, 2019
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the version/15.0.13/RC1 branch from a7bb374 to 47f2618 Compare October 30, 2019 18:55
@kesselb
Copy link
Collaborator

kesselb commented Oct 30, 2019

Please don't forget about: #17540 (comment)

@rullzer
Copy link
Member Author

rullzer commented Oct 30, 2019

Was done in 965a7b3 ;)

@kesselb
Copy link
Collaborator

kesselb commented Oct 30, 2019

Sneaky ;) Is it enough? If $this->path is null it will 💥

@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 30, 2019
@rullzer
Copy link
Member Author

rullzer commented Oct 30, 2019

Sneaky ;) Is it enough? If $this->path is null it will boom

Yeah fair point
care to shoot in a PR?

@rullzer
Copy link
Member Author

rullzer commented Oct 30, 2019

Sneaky ;) Is it enough? If $this->path is null it will boom

Yeah fair point
care to shoot in a PR?

let me do it actually and then you press approve ;)

@rullzer
Copy link
Member Author

rullzer commented Oct 30, 2019

#17760

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer merged commit 8284f12 into stable15 Oct 31, 2019
@rullzer rullzer deleted the version/15.0.13/RC1 branch October 31, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews overview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants