Let SCSS cleanup only run once #17543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
approved these changes
Oct 15, 2019
kesselb
reviewed
Oct 15, 2019
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/14615
branch
from
516a0a9 to
ee74386
Compare
ChristophWurst
approved these changes
Oct 17, 2019
ChristophWurst
added
4. to release
|
/backport to stable17 |
|
/backport to stable16 |
|
backport to stable17 in #17579 |
|
backport to stable16 in #17580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #14615
I could not reliably reproduce the bug bug I encountered that there might be cases where the first request encounters that the scss variables have changed, clears the cache and during the same time another request does the same. This PR makes sure that the cache cleanup is only running once.