Skip to content

[stable16] Use handlebars from node_modules (on CI) #17347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

[stable16] Use handlebars from node_modules (on CI) #17347

merged 1 commit into from
Oct 1, 2019

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 1, 2019 •
edited by ChristophWurst
Loading

No description provided.

@skjnldsv skjnldsv mentioned this pull request Oct 1, 2019
Merged
@rullzer rullzer added this to the Nextcloud 16.0.6 milestone Oct 1, 2019
@ChristophWurst ChristophWurst changed the title Use handlebars from node_modules (on CI) [stable16] Use handlebars from node_modules (on CI) Oct 1, 2019
@rullzer
Copy link
Member

rullzer commented Oct 1, 2019

ci says no: https://drone.nextcloud.com/nextcloud/server/22032/4/3

@skjnldsv skjnldsv force-pushed the backport/stable16/fix/hbs-compile-script branch from 400e50b to 3880851 Compare October 1, 2019 07:17
@ChristophWurst
Copy link
Member

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.11.0/linux-x64-72_binding.node

HTTP error 404 Not Found

Apparently they remove their artifacts when new releases are published.

@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 1, 2019 •
edited
Loading

Found it. We need node-sass@4.12.0 for Node 12. Older release don't work: https://github.com/sass/node-sass/releases/tag/v4.11.0

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 1, 2019

Found it. We need 4.12.0 for Node 12. Older release don't work: https://github.com/sass/node-sass/releases/tag/v4.11.0

so what do we do?

@ChristophWurst
Copy link
Member

so what do we do?

Either downgrade the Docker image to Node <= 11 or update node-sass to 4.12.0

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 1, 2019

Node <= 11

I would prefer this, let's go for node lts?

@ChristophWurst
Copy link
Member

I would prefer this, let's go for node lts?

Fine by me. Or node:11

@skjnldsv skjnldsv force-pushed the backport/stable16/fix/hbs-compile-script branch from 3880851 to 86bd86f Compare October 1, 2019 09:23
@ChristophWurst @skjnldsv
Use handlebars from node_modules (on CI)
d513d56 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv skjnldsv force-pushed the backport/stable16/fix/hbs-compile-script branch from 86bd86f to d513d56 Compare October 1, 2019 09:23
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 1, 2019 •
edited
Loading

Handlbr tests passed

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 1, 2019
@rullzer rullzer merged commit c7157ef into stable16 Oct 1, 2019
@rullzer rullzer deleted the backport/stable16/fix/hbs-compile-script branch October 1, 2019 10:07
@rullzer rullzer mentioned this pull request Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug technical debt

Projects

None yet

Milestone

Nextcloud 16.0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @rullzer @ChristophWurst