Skip to content

[stable16] Properly initialize the CacheJail for sharing #17061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2019
Merged

[stable16] Properly initialize the CacheJail for sharing #17061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55b416c
Properly initialize the CacheJail for sharing
juliusknorr Sep 3, 2019
a7c0bb0
Correctly check for new default root
nickvergessen Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/files_sharing/lib/Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@ public function __construct($storage, ICacheEntry $sourceRootInfo) {

parent::__construct(
null,
null
''
);
}

protected function getRoot() {
if (is_null($this->root)) {
if ($this->root === '') {
$absoluteRoot = $this->sourceRootInfo->getPath();

// the sourceRootInfo path is the absolute path of the folder in the "real" storage
Expand Down Expand Up @@ -138,7 +138,7 @@ public function moveFromCache(\OCP\Files\Cache\ICache $sourceCache, $sourcePath,

protected function formatCacheEntry($entry, $path = null) {
if (is_null($path)) {
$path = isset($entry['path']) ? $entry['path'] : '';
$path = $entry['path'] ?? '';
$entry['path'] = $this->getJailedPath($path);
} else {
$entry['path'] = $path;
Expand Down