fix "create folder" icon overlaying home icon #17017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ritsute 👍 Would you mind to sign off your commits? https://github.com/nextcloud/server/pull/17017/checks?check_run_id=212969543 for more details. |
Signed-off-by: Brandon <brandon.yeow@websparks.sg>
ritsute
force-pushed
the
fix/css-actions.creatable
branch
from
2a6c8b6 to
a67941f
Compare
skjnldsv
approved these changes
Sep 16, 2019
juliusknorr
added
the
4. to release
|
/backport to stable17 |
|
/backport to stable16 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
backport to stable17 in #17219 |
|
/backport to stable16 |
|
backport to stable16 in #17227 |
This was referenced Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First contribution. Home icon is blocked. I've edited CSS from absolute to relative and adjusted position accordingly.
Steps to reproduce
Go to any uploaded files and right click on it, select "Move or Copy"
Actual behaviour
"Create new folder" icon is overlaying "home" icon.
Expected behaviour
"Create new folder" icon should be to the left of "span.dirtree.breadcrumb", not covering "Home" icon.
Server configuration
Operating system:
Ubuntu 18.04
Web server:
apache2 2.4.29
Database:
mysql 5.8
PHP version:
7.2.19
Nextcloud version: (see Nextcloud admin page)
16.0.4
Updated from an older Nextcloud/ownCloud or fresh install:
fresh installed. Currently updates using settings/admin/overview button.
Where did you install Nextcloud from:
single php file from nextcloud deploy.