Properly initialize the CacheJail for sharing #16985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
blizzz,
icewind1991,
nickvergessen and
rullzer
rullzer
approved these changes
Sep 3, 2019
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
nickvergessen
approved these changes
Sep 9, 2019
|
/backport to stable17 |
|
/backport to stable16 |
|
/backport to stable15 |
|
Failures are unrelated |
|
backport to stable17 in #17060 |
|
backport to stable16 in #17061 |
|
backport to stable15 in #17062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #16911
The set root path is expected to be an empty string instead of null when obtaining the jailed path in
server/lib/private/Files/Cache/Wrapper/CacheJail.php
Line 71 in 0487144
This fixes two issues when sharing a complete group folder:
Search:
💥 Filename not displayed properly and path is set wrong
✔️ File is displayed and linked properly
Activity:
💥 The activity app for the admin shows a broken entry
✔️ The activity app for the admin shows the correct file entry