Skip to content

Conversation

@kyrofa
Copy link
Member

@kyrofa kyrofa commented Aug 15, 2019

This is a backport of #16507 (fixing #15416) for stable16. There were some conflicts, so the automatic backport failed.

This is a backport of nextcloud#16507 (fixing nextcloud#15416) for stable16.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa
Copy link
Member Author

kyrofa commented Aug 15, 2019

@georgehrke does this look right to you?

@kyrofa
Copy link
Member Author

kyrofa commented Aug 15, 2019

The drone errors appear unrelated.

@kyrofa
Copy link
Member Author

kyrofa commented Aug 16, 2019

@nickvergessen and @MorrisJobke you were both involved in that PR as well, mind taking a quick look at this one?

@kesselb kesselb added this to the Nextcloud 16.0.5 milestone Aug 16, 2019
@kesselb kesselb added 3. to review Waiting for reviews bug labels Aug 16, 2019
@nickvergessen
Copy link
Member

Which conflicts were involved? are there other backports missing?

@kyrofa
Copy link
Member Author

kyrofa commented Aug 20, 2019

Which conflicts were involved?

No big ones, the API was just different between versions is all so it wasn't a clean cherry pick. There should be no behavioral changes.

are there other backports missing?

Not of which I'm aware.

@violoncelloCH
Copy link
Member

looks like the backport to stable15 failed as well...

@kyrofa
Copy link
Member Author

kyrofa commented Aug 22, 2019

Indeed, probably for similar reasons.

@nickvergessen
Copy link
Member

/backport to stable15

@kyrofa
Copy link
Member Author

kyrofa commented Aug 27, 2019

Hey folks, any progress here?

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense :)

@skjnldsv skjnldsv added the high label Sep 4, 2019
Copy link
Member

@violoncelloCH violoncelloCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer merged commit cf2af05 into nextcloud:stable16 Sep 4, 2019
@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

@kyrofa kyrofa deleted the backport_16/15416/update_autodisabled_apps branch September 4, 2019 17:36
@rullzer rullzer mentioned this pull request Sep 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants