Skip to content

Conversation

@georgehrke
Copy link
Member

Signed-off-by: Georg Ehrke developer@georgehrke.com

@georgehrke georgehrke added the 3. to review Waiting for reviews label Aug 12, 2019
@georgehrke georgehrke added this to the Nextcloud 17 milestone Aug 12, 2019
@skjnldsv
Copy link
Member

It's the same issue, the cross doesn't make sense in Hinduism, Islam, Shintoism, Buddhism... :)

@georgehrke
Copy link
Member Author

@skjnldsv As roeland said, Google calendar uses the same. Otherwise pull-requests are always welcome 😉

@skjnldsv
Copy link
Member

@georgehrke I'd remove the emoji totally. :)

@georgehrke
Copy link
Member Author

georgehrke commented Aug 12, 2019

But then you end up with Name (year). That's not very self-explanatory.
If anything, we could change it to Death of Name

@skjnldsv
Copy link
Member

Sounds good to me :)
What do you think? (also cc @jancborchardt)

@jancborchardt
Copy link
Member

Alright, so relevant reading:

So there just seem to be too many symbols and too many connotations.


The only symbol that could maybe work as also in symmetry with the birthday cake might be:
🥀 wilted flower

What do you think?

@skjnldsv
Copy link
Member

Feels a bit sad to me :)
A good shape flower would be nice 😛

@jancborchardt
Copy link
Member

Then let’s just avoid any symbolic issues and simply go with "Death of Name (Year)" as @georgehrke mentioned previously.

@georgehrke
Copy link
Member Author

Okay, i will look into this next week.

@georgehrke georgehrke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 15, 2019
@rullzer rullzer mentioned this pull request Aug 18, 2019
@georgehrke georgehrke force-pushed the bugfix/noid/remove_coffin branch from e6006a4 to bf59f48 Compare August 21, 2019 08:35
@georgehrke
Copy link
Member Author

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 21, 2019
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI does 💥

@rullzer rullzer mentioned this pull request Aug 23, 2019
@georgehrke georgehrke force-pushed the bugfix/noid/remove_coffin branch from bf59f48 to d70948f Compare August 26, 2019 08:35
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/remove_coffin branch from d70948f to befe38e Compare August 26, 2019 08:37
@skjnldsv skjnldsv requested a review from rullzer August 26, 2019 09:40
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish enhancement and removed 3. to review Waiting for reviews labels Aug 26, 2019
@georgehrke
Copy link
Member Author

CI is happy except for the usual couple of databases that went away

@rullzer rullzer merged commit 6df6fc5 into master Aug 26, 2019
@rullzer rullzer deleted the bugfix/noid/remove_coffin branch August 26, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants