Skip to content

Fix alignment issues in admin settings #16236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2019
Merged

Fix alignment issues in admin settings #16236

merged 1 commit into from
Jul 7, 2019

Conversation

@gary-kim
Copy link
Member

@gary-kim gary-kim commented Jul 4, 2019 •
edited
Loading

For #16076

  • Overview: Version info i icon not vertically aligned correctly
  • Basic settings: Cron settings alignment issues: info i not correctly vertically aligned, detail text of radio buttons should be flush with first line
  • Groupware: Also text alignment issues, indent the subline to be flush with first line

EDIT: Forgot to put the last one in the list.

@gary-kim
Fix alignment issues in admin settings
c9ef40a 
Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim added bug 3. to review Waiting for reviews labels Jul 4, 2019
@gary-kim gary-kim added this to the Nextcloud 17 milestone Jul 4, 2019
juliusknorr
juliusknorr approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks a lot

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 5, 2019
@jancborchardt jancborchardt mentioned this pull request Jul 5, 2019
Closed
77 tasks
@skjnldsv skjnldsv merged commit 1f4312f into nextcloud:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

3 participants

@gary-kim @juliusknorr @skjnldsv