Skip to content

Do not show app score if it has no ratings #16141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2019
Merged

Do not show app score if it has no ratings #16141

merged 1 commit into from
Jul 2, 2019

Conversation

@ChristophWurst
Copy link
Member

For #16076

"No ratings" shows as 2.5 stars – should not show anything (also fixes issue of showing ratings for official apps)

@ChristophWurst
Do not show app score if it has no ratings
48761ae 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 17 milestone Jun 28, 2019
@ChristophWurst ChristophWurst self-assigned this Jun 28, 2019
@jancborchardt jancborchardt mentioned this pull request Jun 28, 2019
Closed
77 tasks
georgehrke
georgehrke approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

GretaD
GretaD approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

jancborchardt
jancborchardt approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing and looks good!

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 1, 2019
@MorrisJobke MorrisJobke merged commit 85f371a into master Jul 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/no-rating-no-score branch July 2, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@georgehrke georgehrke georgehrke approved these changes

@GretaD GretaD GretaD approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

8 participants

@ChristophWurst @rullzer @jancborchardt @georgehrke @GretaD @MorrisJobke @juliusknorr