Skip to content

Remove duplicate close-icon #16122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

Remove duplicate close-icon #16122

merged 1 commit into from
Jun 27, 2019

Conversation

@GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 27, 2019

Ref: #16076
Used to be like this:
close-icon_old
Now it looks like this:
close-icon

@GretaD
Remove duplicate close-icon
32abff5 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD added 3. to review Waiting for reviews bug design Design, UI, UX, etc. labels Jun 27, 2019
@jancborchardt jancborchardt mentioned this pull request Jun 27, 2019
Closed
77 tasks
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 27, 2019
jancborchardt
jancborchardt approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What about the drone failures? :)

@rullzer rullzer merged commit e648c07 into master Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/apps/sidebar-close-icon branch June 27, 2019 20:11
@GretaD GretaD self-assigned this Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@GretaD GretaD

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GretaD @jancborchardt @ChristophWurst @juliusknorr @skjnldsv @rullzer