Fix download link included in public share page with hidden download #16114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preview element in the public share page was always wrapped with a link to download the file; now that link is included only if the "Hide download" option of the share is not enabled. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable16 |
|
/backport to stable15 |
rullzer
approved these changes
Jun 27, 2019
delete-merged-branch
bot
deleted the
fix-download-link-included-in-public-page-share-with-hidden-download
branch
|
backport to stable16 in #16125 |
|
backport to stable15 in #16126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview element in the public share page was always wrapped with a link to download the file; now that link is included only if the Hide download option of the share is not enabled.
Unfortunately the acceptance tests could not be extended to check this behaviour as text files do not had this issue and it is currently not possible to upload new files to test it, for example, with a zip file.
How to test
Result with this pull request
The preview icon is shown, but clicking on it does nothing.
Result without this pull request
The preview icon is shown and clicking on it triggers a download of the file.