Skip to content

Only return link to themed icon if file exists #16095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2019
Merged

Only return link to themed icon if file exists #16095

merged 1 commit into from
Jun 26, 2019

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 26, 2019 •
edited by kesselb
Loading

Close #16058

This makes sure we only return an URL to the imagePath method if the file exists.

Fixes issue mentioned in #16076

.mp4 filetype uses non-existing "video-mp4.svg" as mimetype icon, but we only have "video.svg" and should use that

@juliusknorr
Only return link to themed icon if file exists
ec6ce43 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr mentioned this pull request Jun 26, 2019
Closed
@jancborchardt jancborchardt mentioned this pull request Jun 26, 2019
Closed
77 tasks
@jancborchardt jancborchardt merged commit 810e5f4 into master Jun 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/theming-filetypes branch June 26, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: theming

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr @kesselb @skjnldsv @jancborchardt