Allow multiple names and description

[nickvergessen]

• Fix translatable name
• Fix translatable summary
• Fix translatable description
• Fix multiple authors
• Fallback from de_DE to de

Fix #1466

@janis91 @JSoko feel free to test.

@BernhardPosselt since you introduced this new feature with the app store.

@MorrisJobke @LukasReschke
I think we should backport this, because otherwise an app with such values renders the app management page useless

[codecov-io]

Current coverage is 30.70% (diff: 22.50%)

Merging #1586 into master will increase coverage by 0.09%

@@             master      #1586   diff @@
==========================================
  Files          1082       1082          
  Lines         60063      60200   +137   
  Methods        6810       6827    +17   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          18387      18487   +100   
- Misses        41676      41713    +37   
  Partials          0          0          

Diff Coverage	File Path
•• 22%	lib/private/legacy/app.php

Powered by Codecov. Last update 99076a8...53ed3da

[janis91]

For me the page shows up now and the app is listed. BUT: As the specification of the appstore fields for the description suggests, my app is using markdown. And as you can see, this is not supported yet:
http://imgur.com/a/JolnG

Maybe it is an option to show the summary field instead of the description.. Makes more sense IMHO

[janis91]

And maybe it would be even nicer to show the correct language if available.

[JSoko]

For me the page shows up now and the app is listed.

Works here too! :-)

[nickvergessen]

Yeah we don't support any mark up yet...

[nickvergessen]

And maybe it would be even nicer to show the correct language if available.

That is already done

[janis91]

That is already done

As you can see in the screenshot I mentioned above, this isn't the case for me.

[nickvergessen]

Maybe you use the language de_DE which is not defined for this app?

[janis91]

I don't provide any translation files for this app, yet. But the info.xml has a description and a summary tag present. In a "en" and "de" version. Is this wrong?

[BernhardPosselt]

@janis91 no, if you run de_DE it should fall back to de if de_DE is not present as translation.

And ofc then fall back to en if de is not present

[janis91]

How do I actually run "de_DE" ? I just work with a browser setup in german. And the whole nextcloud shows up in german. The only thing that is not used is the german translation in the appinfo/info.xml of my app. It is present like follows:
<description lang="en"></description> and
<description lang="de"></description>

The only thing which is completely missing (I don't know if that has an influence on that) is the transifex setup and therefore the appropriate en.json and de.json files, because it is only requested yet.

[BernhardPosselt]

You can switch the language in your profile

[nickvergessen]

Added todo "Fallback from de_DE to de"

[janis91]

I looked into it and this definetly causes the problem. I think the fallback is the right way! Thanks!

[nickvergessen]

Added the language fallback from de to de_DE and the other way around.

[janis91]

tested it. and it works! nice 👍
(although the markdown is not supported yet)

[nickvergessen]

Markdown is being discussed in #1594

[MorrisJobke]

Tested and works 👍