Skip to content

[stable15] Handle 0 B default quota properly in the web UI #15425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2019
Merged

[stable15] Handle 0 B default quota properly in the web UI #15425

merged 2 commits into from
May 8, 2019

Conversation

@juliusknorr
Copy link
Member

Backport of #15359

juliusknorr added 2 commits May 7, 2019 18:42
@juliusknorr
Fix default quota setting of 0 B
956e545 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump user settings bundle
5290686 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels May 7, 2019
@juliusknorr juliusknorr added this to the Nextcloud 15.0.8 milestone May 7, 2019
@juliusknorr juliusknorr mentioned this pull request May 7, 2019
Merged
@ChristophWurst
Copy link
Member

Have you run npm i inside settings before building? I have the feeling unrelated webpack bundles got touched.

@ChristophWurst
Copy link
Member

Bildschirmfoto von 2019-05-07 19-53-24
rebuilding this branch locally gives me these changes

@juliusknorr
Copy link
Member Author

Have you run npm i inside settings before building? I have the feeling unrelated webpack bundles got touched.

npm ci, yes ... let me recheck

@juliusknorr
Copy link
Member Author

@ChristophWurst No, even after a make this is the result 😕

@juliusknorr
Copy link
Member Author

Ok the files are actually not up to date on the stable15 branch:
image

@rullzer rullzer mentioned this pull request May 7, 2019
Merged
@MorrisJobke MorrisJobke merged commit 585c090 into stable15 May 8, 2019
@MorrisJobke MorrisJobke deleted the backport/stable15/15359 branch May 8, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 15.0.8

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr @ChristophWurst @MorrisJobke @skjnldsv