[stable15] Disable the injected snapper logic when apps want to ship their own #15046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows apps to ship their own, as in some cases the #app-content element does not exist on page load and therefore the injection fails and the icon is missing afterwards. Fixes #14956 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
backportbot-nextcloud
bot
added
bug
design
backportbot-nextcloud
bot
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr,
nickvergessen,
rullzer and
skjnldsv
skjnldsv
approved these changes
Apr 11, 2019
ChristophWurst
approved these changes
Apr 11, 2019
skjnldsv
added
the
4. to release
|
Failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #14972