Do not issue update command if nothing has changed in user values#14967
Merged
MorrisJobke merged 3 commits intomasterfrom Apr 11, 2019
Merged
Do not issue update command if nothing has changed in user values#14967MorrisJobke merged 3 commits intomasterfrom
MorrisJobke merged 3 commits intomasterfrom
Conversation
Member
Author
|
Let me debug this later today |
Member
Author
|
Partially added via #15052 to properly debug the CI failure in smaller steps. |
MorrisJobke
force-pushed
the
lib-private-user-trigger-pass-old
branch
from
146333b to
9a5ca23
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added
3. to review
MorrisJobke
commented
Apr 11, 2019
|
|
||
| public function setDisplayName($uid, $displayName) { | ||
| $this->displayNames[$uid] = $displayName; | ||
| return true; |
Member
Author
There was a problem hiding this comment.
I found the cause of the failure - no idea why it worked before, but it was also failing locally and this fixed it locally for me as well 🙌
MorrisJobke
requested review from
ChristophWurst,
blizzz,
kesselb,
nickvergessen and
rullzer
ChristophWurst
approved these changes
Apr 11, 2019
MorrisJobke
added
4. to release
kesselb
reviewed
Apr 11, 2019
| $displayName = trim($displayName); | ||
| if ($this->backend->implementsActions(Backend::SET_DISPLAYNAME) && !empty($displayName)) { | ||
| $oldDisplayName = $this->getDisplayName(); | ||
| if ($this->backend->implementsActions(Backend::SET_DISPLAYNAME) && !empty($displayName) && $displayName !== $oldDisplayName) { |
Contributor
There was a problem hiding this comment.
Make sense. Just a small nitpick: !empty($displayName) && $displayName !== $oldDisplayName is cheaper than implementsActions.
Member
Author
There was a problem hiding this comment.
Something for later I would say.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #14566 but rebased on master so that we can debug the failing CI.