Fix required permissions for webdav move and copy #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @icewind1991, @PVince81 and @DeepDiver1975 to be potential reviewers |
|
Makes sense! |
|
Found the breaking PR #255 (wasn't linked from the commit, but via backport it worked) Vincent even commented exactly this: #255 (comment) |
|
Tested and works 👍 |
MorrisJobke
deleted the
fix-required-permissions-for-webdav-move-and-copy
branch
This was referenced Sep 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3571207 broke the
test_sharePermissions.pysmashbox test@rullzer @MorrisJobke @schiessle
Should backport to 10 and 9