Fix UniqueConstraintViolationException while insert into oc_file_locks #12413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes #9305 by not being prone to the race condition in insertIfNotExists * fixes #6899 by not using a query that can result in a deadlock * replaces the insertIfNotExists call with an insert which is wrapped into a try-catch block * followup to #12371 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
blizzz,
icewind1991,
nickvergessen and
rullzer
nickvergessen
approved these changes
Nov 12, 2018
This was referenced Nov 12, 2018
Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction
#6899
Closed
blizzz
added
4. to release
This was referenced Nov 12, 2018
Merged
|
Since this will be backported, is there a PR or issue I can follow to track when this makes it into v14? |
|
#12433 will be part of https://github.com/nextcloud/server/milestone/57 |
|
HI, just upgraded to Nextcloud 15.0.4, the problem persists. The postgresql logs are polluted by these 5 times a second: Everything seems to work fine, but this is slowing down the system a lot which crawls under postgresql load. |
Fix for this is in #13721 |
|
Issue is backup again in #6899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would back port this one to stable13 and stable14 as well because it is a smaller and not that invasive version of #12371 and it also fixes the deadlocks.