Fix UniqueConstraintViolationException while insert into oc_filecache#12411
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 12, 2018
Merged
Fix UniqueConstraintViolationException while insert into oc_filecache#12411MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
89ba561 to
93c62d7
Compare
MorrisJobke
commented
Nov 12, 2018
| $builder->insert('filecache'); | ||
|
|
||
| foreach ($values as $column => $value) { | ||
| $builder->setValue($column, $builder->createNamedParameter($value)); |
Member
Author
There was a problem hiding this comment.
It also said, that there is an sql injection problem (this came from our plugin to Phan). I double checked and the column as well as the argument are both properly escaped.
nickvergessen
approved these changes
Nov 12, 2018
JanDragon
approved these changes
Nov 12, 2018
This was referenced Nov 12, 2018
Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction
#6899
Closed
kesselb
approved these changes
Nov 12, 2018
Contributor
Query looks good and unique constraint is working. |
Member
Author
Yep - I didn't changed anything there. We can tackle the types later, but for now I want to go for the least intrusive way. |
This was referenced Nov 12, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would back port this one to stable13 and stable14 as well because it is a smaller and not that invasive version of #12371 and it also fixes the deadlocks.