Add job to check users for backup code reminders #11549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Oct 2, 2018
| protected function run($argument) { | ||
| $this->userManager->callForSeenUsers(function(IUser $user) { | ||
| $providers = $this->registry->getProviderStates($user); | ||
| $enabledProviders = $this->twofactorManager->isTwoFactorAuthenticated($user); |
Member
There was a problem hiding this comment.
$isTwoFactorAuthenticated?
| $providers = $this->registry->getProviderStates($user); | ||
| $enabledProviders = $this->twofactorManager->isTwoFactorAuthenticated($user); | ||
|
|
||
| if ($enabledProviders && $providers['backup_codes'] === false) { |
Member
There was a problem hiding this comment.
it should be set, but maybe add a isset check for the backup_codes key for the case that the registry state is not yet populated
MorrisJobke
approved these changes
Oct 2, 2018
Now that we can enforce 2FA we also should notify users that have enabled 2FA but do not yet have backup codes generated. This adds a repair step that inserts a background job to do this. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
feature/background_job_to_check
branch
from
f043e97 to
36bf522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can enforce 2FA we also should notify users that have
enabled 2FA but do not yet have backup codes generated.
This adds a repair step that inserts a background job to do this.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl