Conversation
weeman1337
added
design
core/css/header.scss
Outdated
| background-position: center; | ||
| width: 62px; | ||
| height: 100%; | ||
| height: calc(100% - 2px); |
There was a problem hiding this comment.
I'm cinfused, where does those 2px come from? 🤔 😁
There was a problem hiding this comment.
@skjnldsv it has top: 1px;. When there should be the same at the bottom a height of 100 % minus two pixels would to that.
There was a problem hiding this comment.
Shouldn't we set a top at 0?
I remember something about this, but I can't recall 😁
There was a problem hiding this comment.
ha ha :) I tried it without the tiny spacing. In my opinion it looks better like this...
There was a problem hiding this comment.
you could add a bottom: 1px? so we understand better?
I'm fine with that, but i'm afraid we'll forget about this like I did above 😝
weeman1337
force-pushed
the
11372/fix/logo-height
branch
from
f948916 to
46bd4c4
Compare
|
I tested it also. 👍 |
|
@go2sh you should be able to add your review on the top right ;) |
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
rullzer
force-pushed
the
11372/fix/logo-height
branch
from
46bd4c4 to
c7714b4
Compare
|
@weeman1337 Once the backport PR is open you could remove the |
5 participants
before
after
Closes #11372