Fix backup codes column length for Argon2 values #10771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
bug
2. developing
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
3. to review
|
@rullzer I expected my first commit to trigger some CI errors, but it seems all okay. How's that possible? How can I find out if my tests are even executed? |
|
@ChristophWurst good question let me have a look |
|
Tests are not executed as per: Line 13 in 2c0743c so that is why they don't fail :P |
Apparently the Nextcloud server ignores tests that have `Integration` in their fully-qualified class name, hence the backup codes integration tests were removed. This moves them up one directory (out of `Integration`) to fix that. Real unit tests remain in the `Unit` directory. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
approved these changes
Aug 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new (php7.2) hasher's values are a bit longer than the ones of the old algorithm, hence we have to increase the column length.
Fixes #10766.