[Bug]: Undefined array key "color" at /var/www/html/apps/dav/lib/SystemTag/SystemTagsInUseCollection.php#76

[mabod]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

I see the following warnings in the log:

Undefined array key "color" at /var/www/html/apps/dav/lib/SystemTag/SystemTagsInUseCollection.php#76

I am using nextcloud with docker on a debian server. nextcloud:31.0.7-fpm

Steps to reproduce

I do not know how to reproduce this. I have "memories" and "recognize" installed. And when I check the "tags" page I sometimes see this warning. If it happens it is immediately several hundred warnings at once.

Its the same issue that was reported here: nextcloud/all-in-one#6213

Expected behavior

I would expect to see no warning.

Nextcloud Server version

31

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "upgrade.disable-web": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "debserv",
            "192.168.132.49",
            "nxcloud.bodenbinder.de"
        ],
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "overwritehost": "nxcloud.bodenbinder.de",
        "overwriteprotocol": "https",
        "overwrite.cli.url": "https:\/\/nxcloud.bodenbinder.de",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "password": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "31.0.7.1",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "default_phone_region": "DE",
        "maintenance_window_start": 1,
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "loglevel": 2,
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "app_install_overwrite": [],
        "memories.exiftool": "\/var\/www\/html\/custom_apps\/memories\/bin-ext\/exiftool-amd64-glibc",
        "memories.vod.path": "\/var\/www\/html\/custom_apps\/memories\/bin-ext\/go-vod-amd64",
        "enable_previews": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\BMP",
            "OC\\Preview\\GIF",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\Krita",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\MP3",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\PNG",
            "OC\\Preview\\TXT",
            "OC\\Preview\\XBitmap"
        ],
        "memories.db.triggers.fcu": true,
        "memories.gis_type": 1,
        "memories.vod.disable": false,
        "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg",
        "memories.vod.ffprobe": "\/usr\/bin\/ffprobe",
        "memories.vod.vaapi": true
    }
}

List of activated Apps

Enabled:
  - activity: 4.0.0
  - announcementcenter: 7.1.4
  - app_api: 5.0.2
  - bruteforcesettings: 4.0.0
  - cloud_federation_api: 1.14.0
  - comments: 1.21.0
  - contactsinteraction: 1.12.0
  - dashboard: 7.11.0
  - dav: 1.33.0
  - federatedfilesharing: 1.21.0
  - federation: 1.21.0
  - files: 2.3.1
  - files_downloadlimit: 4.0.0
  - files_external: 1.23.0
  - files_pdfviewer: 4.0.0
  - files_reminders: 1.4.0
  - files_sharing: 1.23.1
  - files_trashbin: 1.21.0
  - files_versions: 1.24.0
  - firstrunwizard: 4.0.0
  - logreader: 4.0.0
  - lookup_server_connector: 1.19.0
  - memories: 7.6.1
  - nextcloud_announcements: 3.0.0
  - notes: 4.12.2
  - notifications: 4.0.0
  - oauth2: 1.19.1
  - password_policy: 3.0.0
  - photos: 4.0.0
  - previewgenerator: 5.9.0
  - privacy: 3.0.0
  - profile: 1.0.0
  - provisioning_api: 1.21.0
  - recognize: 9.0.3
  - recommendations: 4.0.0
  - related_resources: 2.0.0
  - richdocuments: 8.7.2
  - richdocumentscode: 25.4.202
  - serverinfo: 3.0.0
  - settings: 1.14.0
  - sharebymail: 1.21.0
  - support: 3.0.0
  - survey_client: 3.0.0
  - systemtags: 1.21.1
  - text: 5.0.0
  - theming: 2.6.1
  - twofactor_backupcodes: 1.20.0
  - updatenotification: 1.21.0
  - user_status: 1.11.0
  - viewer: 4.0.0
  - weather_status: 1.11.0
  - webhook_listeners: 1.2.0
  - workflowengine: 2.13.0
Disabled:
  - admin_audit: 1.21.0
  - calendar: 5.3.6 (installed 5.3.6)
  - circles: 31.0.0 (installed 30.0.0)
  - contacts: 7.2.0 (installed 7.2.0)
  - encryption: 2.19.0
  - facerecognition: 0.9.70 (installed 0.9.70)
  - mail: 5.1.8 (installed 5.1.8)
  - spreed: 21.1.2 (installed 21.1.2)
  - suspicious_login: 9.0.1
  - twofactor_nextcloud_notification: 5.0.0
  - twofactor_totp: 13.0.0-dev.0
  - user_ldap: 1.22.0

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[joshtrichards]

Looks related to #49295.

I'm not familiar with this area of code, but a quick look suggests maybe handling for the systemtag.color column is missing here:

server/lib/private/Files/Cache/CacheQueryBuilder.php

Lines 29 to 46 in 4eda352

	public function selectTagUsage(): self {
	$this
	->select('systemtag.name', 'systemtag.id', 'systemtag.visibility', 'systemtag.editable', 'systemtag.etag')
	->selectAlias($this->createFunction('COUNT(filecache.fileid)'), 'number_files')
	->selectAlias($this->createFunction('MAX(filecache.fileid)'), 'ref_file_id')
	->from('filecache', 'filecache')
	->leftJoin('filecache', 'systemtag_object_mapping', 'systemtagmap', $this->expr()->andX(
	$this->expr()->eq('filecache.fileid', $this->expr()->castColumn('systemtagmap.objectid', IQueryBuilder::PARAM_INT)),
	$this->expr()->eq('systemtagmap.objecttype', $this->createNamedParameter('files'))
	))
	->leftJoin('systemtagmap', 'systemtag', 'systemtag', $this->expr()->andX(
	$this->expr()->eq('systemtag.id', 'systemtagmap.systemtagid'),
	$this->expr()->eq('systemtag.visibility', $this->createNamedParameter(true))
	))
	->groupBy('systemtag.name', 'systemtag.id', 'systemtag.visibility', 'systemtag.editable');
	return $this;
	}

Resulting it the value being empty here:

server/apps/dav/lib/SystemTag/SystemTagsInUseCollection.php

Lines 73 to 77 in 4eda352

	$result = $this->systemTagsInFilesDetector->detectAssignedSystemTagsIn($userFolder, $this->mediaType);
	$children = [];
	foreach ($result as $tagData) {
	$tag = new SystemTag((string)$tagData['id'], $tagData['name'], (bool)$tagData['visibility'], (bool)$tagData['editable'], $tagData['etag'], $tagData['color']);
	// read only, so we can submit the isAdmin parameter as false generally

Cc: @skjnldsv

[mabod]

I tested PR #54121 and it solves this issue for me.
Thanks. This was really quick!

[joshtrichards]

Keeping open until associated PR is accepted/merged. ;)