ETag check of `/navigation/apps` not working

[SystemKeeper]

server/core/Controller/NavigationController.php

Lines 50 to 56 in 07f26fc

	$etag = $this->generateETag($navigation);
	if ($this->request->getHeader('If-None-Match') === $etag) {
	return new DataResponse([], Http::STATUS_NOT_MODIFIED);
	}
	$response = new DataResponse($navigation);
	$response->setETag($etag);
	return $response;

Drive-by observation. I assume we manually check the etag here, as we don't set a cache on the response. But even then, the comparison is not working correctly. Not even sure it really makes sense this way? What do we gain from that extra check?

CC @juliusknorr as you did that part back then.

[juliusknorr]

Yes, I don't see any value in the check since the heavy code part in getting the navigation is always executed, but honestly don't remember details around that code change anymore.