[Bug]: 31.0.0 regression - unable to delete items & contextual bar missing when files_trashbin app is disabled

[tgurr]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Multiple problems arise when files_trashbin app is disabled & a browser console error appears

core-common.js?v=c674de09-20:1 Error: Could not find initial state config of files_trashbin
    at a (core-common.js?v=c674de09-20:1:2536766)
    at u.enabled (files-init.js?v=c674de09-20:1:3055)
    at files-main.js?v=c674de09-20:1:113399
    at Array.filter (<anonymous>)
    at o.enabledFileActions (files-main.js?v=c674de09-20:1:113374)
    at e.get (core-common.js?v=c674de09-20:1:2099233)
    at e.evaluate (core-common.js?v=c674de09-20:1:2100229)
    at o.enabledFileActions (core-common.js?v=c674de09-20:1:2111270)
    at o.enabledInlineActions (files-main.js?v=c674de09-20:1:113515)
    at e.get (core-common.js?v=c674de09-20:1:2099233)

Once you disable the files_trashbin app you're no longer able to delete files as the context menu is missing as well as the contextual bar that is shown when selecting items.

Steps to reproduce

1. Disable files_trashbin app
2. See problems

Expected behavior

1. Disable files_trashbin
2. Have everything working

Nextcloud Server version

31

Operating system

Other

PHP engine version

None

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 31 to 32)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "testcloud.corporate.com"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "31.0.0.18",
        "overwrite.cli.url": "https:\/\/testcloud.corporate.com\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "proxy": "proxy.corporate.com:3128",
        "maintenance": false,
        "loglevel": 2,
        "htaccess.RewriteBase": "\/",
        "maintenance_window_start": 1,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "pipe",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "default_phone_region": "DE",
        "memcache.local": "\\OC\\Memcache\\APCu"
    }
}

List of activated Apps

Enabled:
  - activity: 4.0.0
  - app_api: 5.0.2
  - bruteforcesettings: 4.0.0
  - circles: 31.0.0-dev.0
  - cloud_federation_api: 1.14.0
  - comments: 1.21.0
  - contactsinteraction: 1.12.0
  - dashboard: 7.11.0
  - dav: 1.33.0
  - federatedfilesharing: 1.21.0
  - federation: 1.21.0
  - files: 2.3.1
  - files_downloadlimit: 4.0.0
  - files_pdfviewer: 4.0.0
  - files_reminders: 1.4.0
  - files_sharing: 1.23.1
  - files_versions: 1.24.0
  - firstrunwizard: 4.0.0
  - logreader: 4.0.0
  - lookup_server_connector: 1.19.0
  - notifications: 4.0.0
  - oauth2: 1.19.1
  - password_policy: 3.0.0
  - photos: 4.0.0-dev.1
  - privacy: 3.0.0
  - profile: 1.0.0
  - provisioning_api: 1.21.0
  - recommendations: 4.0.0
  - related_resources: 2.0.0
  - serverinfo: 3.0.0
  - settings: 1.14.0
  - sharebymail: 1.21.0
  - systemtags: 1.21.1
  - text: 5.0.0
  - theming: 2.6.1
  - twofactor_backupcodes: 1.20.0
  - updatenotification: 1.21.0
  - user_status: 1.11.0
  - viewer: 4.0.0
  - weather_status: 1.11.0
  - webhook_listeners: 1.2.0
  - whiteboard: 1.0.5
  - workflowengine: 2.13.0
Disabled:
  - admin_audit: 1.21.0
  - encryption: 2.19.0
  - files_external: 1.23.0
  - files_trashbin: 1.21.0 (installed 1.21.0)
  - nextcloud_announcements: 3.0.0 (installed 1.18.0)
  - support: 3.0.0 (installed 1.12.0)
  - survey_client: 3.0.0 (installed 1.17.0)
  - suspicious_login: 9.0.1
  - twofactor_nextcloud_notification: 5.0.0
  - twofactor_totp: 13.0.0-dev.0
  - user_ldap: 1.22.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

-

Additional info

[binarydad]

Having the same exact issue. Just upgraded my image to 31 from 30. Enabling "Deleted Files" brings it back. I want to keep this app disabled, however.

[joshtrichards]

Fixed in #51394