[Bug]: 31.0.0 RC2 File Drop folder fails

[K3das]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

When uploading a folder through file drop on 31.0.0 rc2, the WebDav MKCOL request fails with Only PUT is allowed on files drop returned in the HTTP response. No errors are displayed in the UI, but "Unknown error during upload" is displayed when trying to cancel the upload.

Steps to reproduce

1. Run NC 31 rc2 (docker run --rm -p 8080:80 lscr.io/linuxserver/nextcloud:develop-version-31.0.0rc2)
2. Create a file drop with default permissions and configuration
3. Upload a folder using "upload folders"

Expected behavior

Folder uploads

Nextcloud Server version

31

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[szaimen]

FYI @susnux

[susnux]

I think we need to split this issue into two:

1. Its a bug that you see the upload folder option
2. Add a feature request to support uploading folders ( Allow uploading folders on file-drop ("upload only") shares #15921 )

Uploading folders also did not work on older Nextcloud versions.
The problem why we forbid this is that for files we ensure they are unique when uploading (or we rename them if needed).
For folders the problem is there is currently no logic to restrict uploaders to the folder they created to prevent writing into new folders of other uploaders.

So this should be fixed first before allowing folder upload.

[MrRinkana]

@susnux The upload folder option being present is not a bug, it allows users to upload the entire contents of a folder (placing all the files in the root of the shared folder). The linked feature request is to also keep the folder structure, which would be awesome but is technically another issue. If the upload folder option is removed, even in its current form, UX for uploading everything in a folder will be bad.

I can only recreate this issue trough drag and dropping a folder - giving me the following two responses from the webui:

• "Files uploaded successfully" <- false! Files not uploaded! That notification is a critical bug, as for example students might think they successfully uploaded their documents, etc.
• "Could not create the folder blabla" <-correct

If I use the "Upload folder" webui option, all works as expected: all files in the folder (including those present in subfolders) are uploaded, but none of the folder structure is kept. No errors nor notifications given in the ui. I guess the "Files uploaded successfully" notification not triggering is a bug here.. Edit: I tested this with a folder containing 1182 files spread over 57 subfolders with varying nesting - all files upload straight into the root of the folder, no errors.

@K3das are you sure you used the menu option and did not drag the folder to the window?

Since me and @K3das are having different experiences, maybe the underlying OS of the browsers matter? I have tested firefox and ms edge running on a linux system.

When I use the menu option, the browsers ask me for confirmation if I want to upload all files from the folder. This does not occur with drag and drop (just fails instantly).
I tested nc 31.0.4

To be clear this option seems to work as expected, given #15921, and should remain:

[MrRinkana]

I tested this a bit more, mostly trying more browsers and OS:ses:

With a test folder with 1549 folders with varying nesting (deepest 37) and 9493 files spread across those folders totalling around 3.5GiB, both MS Edge and Firefox on both linux (opensuse tumbleweed) and windows I observe the following (NC 31.0.4):

The menu option "upload from folders":

• All 9493 files are uploaded regardless of browser or OS, all four times I uploaded the folder.
• No errors are returned to the user; after upload a toast with stating the upload was successful
• Both browsers ask "do you want to upload all files from this directory" (paraphrasing) before upload starts
• All files are dumped in the root of the public share (no folders are created), regardless of how deeply they were in the folder structure

Drag-and-dropping a folder:

• Fails instantly with error "Could not create folder"
• Even though it instantly fails, it shows the same "upload successful" toast
• No files are uploaded

I have however after the tests found I have created a tremendous amounts of error logs in nextcloud.log, all about not being able to create the a folder, but I am currently unsure if both tried methods created them or just the drag and drop. If I have time and bother to bother, I'll clear the log and try again to check.

In summary: I can not recreate OP:s issue on my instance, when following the steps to reproduce literally (using the menu option). All files are uploaded, although flattened to the share folder root, an issue tracked in #15921.

Drag and dropping a folder behaves differently, it is completely broken and shows fallacious messages. This is relevant to this issue even though technically not specified in the steps to reproduce.

[susnux]

Done for next maintenance release of 31. Full support for folder upload in Nextcloud 32.