Add tooltips on server status indicators for federated sharing / tidy up Federated/Federation settings section(s)

[nfebe]

Description

• I just learnt that you DON'T need green status in federation for the servers to actually federate.
• Green status is just to symbolize successful exchange of contact lists which means you can just add the usernames yourself in the search bar without the suggestions and it would work.
• This is an important and relieving discovery for me, because I typically waste a lot of time when trying to get green status with two servers to test federated stuff.

Steps to reproduce

See notes on federating : https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/federated_cloud_sharing_configuration.html

Expected behavior

• I think hovering over the status icons should explain what is possible or what the dots mean right in the UI
• I addition to existing overview text, users can be directed to hover over the status icon to learn more about the current status.

cc: @nextcloud/d

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[joshtrichards]

A red light means the connection failed. The yellow light indicates a successful connection, with no user names exchanged. The green light indicates a successful connection with user names exchanged.

Maybe we change how we indicate the state of things a bit.

It seems there are really four states:

server/apps/federation/lib/TrustedServers.php

Lines 25 to 32 in da591ea

	/** after a user list was exchanged at least once successfully */
	public const STATUS_OK = 1;
	/** waiting for shared secret or initial user list exchange */
	public const STATUS_PENDING = 2;
	/** something went wrong, misconfigured server, software bug,... user interaction needed */
	public const STATUS_FAILURE = 3;
	/** remote server revoked access */
	public const STATUS_ACCESS_REVOKED = 4;

And we try to reduce them to three single color icons:

server/apps/federation/templates/settings-admin.php

Lines 19 to 37 in da591ea

	<ul id="listOfTrustedServers">
	<?php foreach ($_['trustedServers'] as $trustedServer) { ?>
	<li id="<?php p($trustedServer['id']); ?>">
	<?php if ((int)$trustedServer['status'] === TrustedServers::STATUS_OK) { ?>
	<span class="status success"></span>
	<?php
	} elseif (
	(int)$trustedServer['status'] === TrustedServers::STATUS_PENDING ||
	(int)$trustedServer['status'] === TrustedServers::STATUS_ACCESS_REVOKED
	) { ?>
	<span class="status indeterminate"></span>
	<?php } else {?>
	<span class="status error"></span>
	<?php } ?>
	<?php p($trustedServer['url']); ?>
	<span class="icon icon-delete"></span>
	</li>
	<?php } ?>
	</ul>

Maybe:

• OK = Green
• PENDING = Yellow
• REVOKED = Orange?
• FAILURE = Red

Also:

• Green status (maybe the tooltip) could give some indication of when the last successful exchange took place
• the current "yellow" looks more orange than yellow to me.

I addition to existing overview text, users can be directed to hover over the status icon to learn more about the current status.

I've wanted to clean up that entire paragraph a few times already. Maybe we adjust it to something like:

You may optionally create a list of trusted servers for Federation sharing. Trusted servers will share account address books and enable auto-completion in share dialogs. Granting trusted server status and exchanging account directories, however, is not necessary in order to create federated shares. Hover (or click the status icon?) next to a configured trusted server to learn more about the current status.

Should also consider cleaning up the presentation a bit under /settings/admin/sharing (these are fairly inter-related to each other):

• Should Federated Cloud Sharing options and Federation Trusted Servers options be under the same heading or remain distinct under Settings->Sharing?
• The Trusted Servers heading has no context that it's related to, well, Federation
• The Federated Cloud Sharing heading is smaller than the Trusted Servers heading, making it seem less cohesive (I guess this is in part because the former comes via the federatedfilesharing app while the latter comes via the federation app).