Please add JSON output to admin-delegation:show

[sebrhex]

How to use GitHub

• Please use the 👍 reaction to show that you are interested into the same feature.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I'm using a script in order to add admin delegations via occ admin-delegation:add. In order to make it easier to parse already existing delegations so the script doesn't attempt adding it or in order to find delegations which need to be removed I'm looking for an easy way to parse the output of occ admin-delegation:show.

Describe the solution you'd like
I'd be happy if occ admin-delegation:show would support --output=json like most other submodules do.

[joshtrichards]

Makes sense. If you (or someone else) wishes to add it, here's are a couple examples of how it's done:

#26260

https://github.com/nextcloud/server/blob/9cd2e5bed9c373ec204461648bf962cff82855b1/apps/files_external/lib/Command/ListCommand.php

[src-r-r]

Thanks! I'd like to take this one. First NextCloud contribution.

I hope this isn't an odd question, but is there a place where this feature can be unit tested? Or do I just need to visually verify it works? What do you recommend?

Thanks!

[joshtrichards]

You could probably model a new test after the test that exists for the command that already supports json output. Looks like you can find that test here: https://github.com/nextcloud/server/blob/9cd2e5bed9c373ec204461648bf962cff82855b1/apps/files_external/tests/Command/ListCommandTest.php

[src-r-r]

Thanks! Looks like one doesn't exist yet for AdminDelegation, so I'll add it.

For someone rusty with PHP, this is a good re-intro I guess. 😆

[src-r-r]

Pretty close to being done. I welcome feedback at src-r-r@5ea3b34

As a seasoned dev I know that it's vital that unit tests pass. However, I'm not sure how to properly construct a SettingsManager such that the sections show up.

If I run occ manually I get the expected data:

$ ./occ admin-delegation:show --output=json
{"overview":[{"name":"Security & setup warnings","class":"OCA\\Settings\\Settings\\Admin\\Overview","groups":[]}],"server":[{"name":"Background jobs","class":"OCA\\Settings\\Settings\\Admin\\Server","groups":[]}],"sharing":[{"name":"Global","class":"OCA\\Settings\\Settings\\Admin\\Sharing","groups":[]}],"theming":[{"name":"Global","class":"OCA\\Theming\\Settings\\Admin","groups":[]}],"ai":[{"name":"Artificial Intelligence","class":"OCA\\Settings\\Settings\\Admin\\ArtificialIntelligence","groups":[]}],"admindelegation":[{"name":"Users","class":"OCA\\Settings\\Settings\\Admin\\Users","groups":[]}]}

But obviously I know I need to get the unit test working.

I was looking at tests/lib/Settings/ManagerTest.php for an example, but that didn't seem to have the right structure. I just end up with an empty array.

[src-r-r]

Alright, figured out how to do it! I'm submitting a PR now!

[src-r-r]

Alright, figured out how to do it. JSON output works for unit tests and OCC. When you are able, please kindly review #47156. Thanks!