[Bug]: Invalid type for field favorite

[tobiasKaminsky]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Webdav SEARCH for favorite is not working

Steps to reproduce

1. create a folder
2. mark it as favorite
3. do webdav SEARCH:

curl --request SEARCH \
  --url http://localhost:8080/remote.php/dav \
  --header 'Authorization: Basic dGVzdDp0ZXN0' \
  --header 'Content-Type: text/xml' \
  --header 'OCS-APIRequest: true' \
  --data '<?xml version="1.0" encoding="UTF-8"?>
<d:searchrequest xmlns:d="DAV:" xmlns:nc="http://nextcloud.com/ns"
								 xmlns:oc="http://owncloud.com/ns">
		<d:basicsearch>
			<d:select>
				<d:prop>
					<d:displayname/>
					<d:getcontenttype/>
					<d:resourcetype/>
					<d:getcontentlength/>
					<d:getlastmodified/>
					<d:creationdate/>
					<d:getetag/>
					<d:quota-used-bytes/>
					<nc:sharees xmlns:nc="http://nextcloud.org/ns"/>
					<d:quota-available-bytes/>
					<oc:permissions xmlns:oc="http://owncloud.org/ns"/>
					<oc:id xmlns:oc="http://owncloud.org/ns"/>
					<oc:size xmlns:oc="http://owncloud.org/ns"/>
					<oc:favorite />
				</d:prop>
			</d:select>
			<d:from>
				<d:scope>
					<d:href>/files/test</d:href>
					<d:depth>infinity</d:depth>
				</d:scope>
			</d:from>
			<d:where>
				<d:eq>
					<d:prop>
						<oc:favorite xmlns:oc="http://owncloud.org/ns"/>
					</d:prop>
					<d:literal>yes</d:literal>
				</d:eq>
			</d:where>
			<d:orderby/>
	</d:basicsearch>
</d:searchrequest>'

4. See:

HTTP 500 error
<?xml version="1.0" encoding="utf-8"?>
<d:error
	xmlns:d="DAV:"
	xmlns:s="http://sabredav.org/ns">
	<s:exception>InvalidArgumentException</s:exception>
	<s:message>Invalid type for field favorite</s:message>
</d:error>

Expected behavior

folder should be shown

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[kesselb]

Good one, well spotted 👍

I guess we have to drop the type hints from SearchComparison.__construct and SearchComparison.getValue again to make it work and adjust the interface in for the next major release to accept bool|int|string|\DateTime.

The current type hint int|string|\DateTime converts the boolean for favorite to an int but the actual search expects an boolean. This works without the type hint because no type juggling is done.

Or add bool to interface and implemention. I don't know if any apps implement it apart from server.

[tobiasKaminsky]

Indeed, using <d:literal>1</d:literal> instead of <d:literal>yes</d:literal> works.
We could change it for our clients, but not for all the other ones, so this needs be reverted on server.

[ArtificialOwl]

Indeed, using <d:literal>1</d:literal> instead of <d:literal>yes</d:literal> works. We could change it for our clients, but not for all the other ones, so this needs be reverted on server.

just checked on 27 and any value was accepted, even <d:literal>false</d:literal> is accepted for true. We might want to have a deeper look into this in a future release.

I have fixed it, following @kesselb instruction; seems to work the same than for 27.

To improve the general behavior on boolean value:

• If we want to be more precise and accept true/false we might want to check on
  

  server/lib/private/Files/Cache/SearchBuilder.php

  Lines 181 to 183 in 380b813

  	} elseif ($field === 'favorite') {
  	$field = 'tag.category';
  	$value = self::TAG_FAVORITE;

• if we want to accept other value than yes (like true or 1) this is where we can add entries to accept:
  

  server/apps/dav/lib/Files/FileSearchBackend.php

  Line 421 in 380b813

  return $value === 'yes';