Skip to content

Can no longer upload files or create folders on public sharing #36510

@nickvergessen

Description

@nickvergessen

You shall not merge with red CI… but, hey, perhaps I get more funny Microsoft Github badges.

Actually the red CI is caused by this:
grafik

grafik

Before After
Bildschirmfoto vom 2023-02-03 09-38-08 Bildschirmfoto vom 2023-02-03 09-37-34
# status: waiting for both good and bad commits
# good: [be1de30a4f6b37da7c710ac55489e4938c4ded91] Fix(l10n): 🔠 Update translations from Transifex
git bisect good be1de30a4f6b37da7c710ac55489e4938c4ded91
# status: waiting for bad commit, 1 good commit known
# bad: [94767112dd4210483394b24d4fdaddea92f0dc8b] Fix(l10n): 🔠 Update translations from Transifex
git bisect bad 94767112dd4210483394b24d4fdaddea92f0dc8b
# good: [e4fadcf02a1146bc454e0217b5883dd2451ed96f] Merge pull request #36434 from nextcloud/techdebt/noid/drop-bootstrap
git bisect good e4fadcf02a1146bc454e0217b5883dd2451ed96f
# good: [fc4e87a2dfc5ff53bc9f15da13f355dd285769a9] Merge pull request #36487 from nextcloud/bugfix/noid/fix-query-builder-usage-in-dav-account-deletion
git bisect good fc4e87a2dfc5ff53bc9f15da13f355dd285769a9
# good: [38e9cb6a052f4d0bc4e34293febbe9f132055a83] Use recurrence instance to build iMip email
git bisect good 38e9cb6a052f4d0bc4e34293febbe9f132055a83
# bad: [39f202581bc72209f2f9c138701281267ba30d39] Merge pull request #36497 from nextcloud/techdebt/noid/fix-autotest-execution
git bisect bad 39f202581bc72209f2f9c138701281267ba30d39
# bad: [d83ea282c4bddd332623c3c0a8c4dea01146047f] Merge pull request #35736 from nextcloud/pluggable-share-display
git bisect bad d83ea282c4bddd332623c3c0a8c4dea01146047f
# good: [6f3c4f2255ed73601fa5eac3048d679caa3065e0] Merge pull request #36450 from nextcloud/fix/clipboard-copy
git bisect good 6f3c4f2255ed73601fa5eac3048d679caa3065e0
# bad: [4ab3c16403e69811cf2353ba2bfeafcbcf259c42] Pluggable share provider
git bisect bad 4ab3c16403e69811cf2353ba2bfeafcbcf259c42
# first bad commit: [4ab3c16403e69811cf2353ba2bfeafcbcf259c42] Pluggable share provider

4ab3c16403e69811cf2353ba2bfeafcbcf259c42 is the first bad commit
commit 4ab3c16403e69811cf2353ba2bfeafcbcf259c42
Author: Louis Chemineau <louis@chmn.me>
Date:   Wed Jan 18 16:53:22 2023 +0100

    Pluggable share provider
    
    Signed-off-by: Carl Schwan <carl@carlschwan.eu>
    Signed-off-by: Louis Chemineau <louis@chmn.me>

 .../composer/composer/autoload_classmap.php        |   1 +
 .../composer/composer/autoload_static.php          |   1 +
 .../lib/Controller/ShareController.php             | 250 +++---------------
 .../lib/DefaultPublicShareTemplateProvider.php     | 292 +++++++++++++++++++++
 apps/files_sharing/templates/public.php            |   2 +-
 .../tests/Controller/ShareControllerTest.php       |  25 +-
 lib/composer/composer/autoload_classmap.php        |   3 +
 lib/composer/composer/autoload_static.php          |   3 +
 .../AppFramework/Bootstrap/RegistrationContext.php |  22 ++
 lib/private/Server.php                             |   2 +
 lib/private/Share20/PublicShareTemplateFactory.php |  63 +++++
 .../Bootstrap/IRegistrationContext.php             |  10 +
 lib/public/Share/IPublicShareTemplateFactory.php   |  35 +++
 lib/public/Share/IPublicShareTemplateProvider.php  |  42 +++
 14 files changed, 532 insertions(+), 219 deletions(-)
 create mode 100644 apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php
 create mode 100644 lib/private/Share20/PublicShareTemplateFactory.php
 create mode 100644 lib/public/Share/IPublicShareTemplateFactory.php
 create mode 100644 lib/public/Share/IPublicShareTemplateProvider.php

Originally posted by @nickvergessen in #35736 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions