[Bug]: NC 25 Error: Undefined array key "extension" at /var/www/nextcloud/apps/files_versions/lib/Storage.php#489

[AndyXheli]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

I was trying to delete alot of files and folders at once

Steps to reproduce

1.Go into a group folder with alot of times
2. Delete the files and folder errors out but deletes
3.

Expected behavior

Should delete with no errors

Installation method

Community Web installer on a VPS or web space

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 22.2.3 to 23.0.1)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

NA

Nextcloud Signing status

No response

Nextcloud Logs

{"reqId":"lNyX2jZtca5uPedBAk5D","level":3,"time":"2022-09-14T16:38:00+00:00","remoteAddr":"10.99.0.65","user":"admin","app":"PHP","method":"DELETE","url":"/remote.php/dav/files/axheli/IT%20Share/KeePass","message":"Undefined array key \"extension\" at /var/www/nextcloud/apps/files_versions/lib/Storage.php#489","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36","version":"25.0.0.11","exception":{"Exception":"Error","Message":"Undefined array key \"extension\" at /var/www/nextcloud/apps/files_versions/lib/Storage.php#489","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/files_versions/lib/Storage.php","line":489,"function":"onError","class":"OC\\Log\\ErrorHandler","type":"::"},{"file":"/var/www/nextcloud/apps/files_versions/lib/Storage.php","line":273,"function":"getVersions","class":"OCA\\Files_Versions\\Storage","type":"::"},{"file":"/var/www/nextcloud/apps/files_versions/lib/Hooks.php","line":71,"function":"delete","class":"OCA\\Files_Versions\\Storage","type":"::"},{"file":"/var/www/nextcloud/lib/private/legacy/OC_Hook.php","line":106,"function":"remove_hook","class":"OCA\\Files_Versions\\Hooks","type":"::"},{"file":"/var/www/nextcloud/lib/private/Files/View.php","line":1284,"function":"emit","class":"OC_Hook","type":"::"},{"file":"/var/www/nextcloud/lib/private/Files/View.php","line":1212,"function":"runHooks","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud/lib/private/Files/View.php","line":349,"function":"basicOperation","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Directory.php","line":305,"function":"rmdir","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Tree.php","line":179,"function":"delete","class":"OCA\\DAV\\Connector\\Sabre\\Directory","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":281,"function":"delete","class":"Sabre\\DAV\\Tree","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpDelete","class":"Sabre\\DAV\\CorePlugin","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":472,"function":"emit","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":253,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":321,"function":"start","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/lib/Server.php","line":360,"function":"exec","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/appinfo/v2/remote.php","line":35,"function":"exec","class":"OCA\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/remote.php","line":167,"args":["/var/www/nextcloud/apps/dav/appinfo/v2/remote.php"],"function":"require_once"}],"File":"/var/www/nextcloud/lib/private/Log/ErrorHandler.php","Line":92,"CustomMessage":"--"},"id":"632203e06c6e9"}

{"reqId":"lNyX2jZtca5uPedBAk5D","level":3,"time":"2022-09-14T16:38:00+00:00","remoteAddr":"10.99.0.65","user":"admin","app":"webdav","method":"DELETE","url":"/remote.php/dav/files/axheli/IT%20Share/KeePass","message":"Unsupported operand types: int - string","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36","version":"25.0.0.11","exception":{"Exception":"TypeError","Message":"Unsupported operand types: int - string","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/files_versions/lib/Storage.php","line":493,"function":"getHumanReadableTimestamp","class":"OCA\\Files_Versions\\Storage","type":"::"},{"file":"/var/www/nextcloud/apps/files_versions/lib/Storage.php","line":273,"function":"getVersions","class":"OCA\\Files_Versions\\Storage","type":"::"},{"file":"/var/www/nextcloud/apps/files_versions/lib/Hooks.php","line":71,"function":"delete","class":"OCA\\Files_Versions\\Storage","type":"::"},{"file":"/var/www/nextcloud/lib/private/legacy/OC_Hook.php","line":106,"function":"remove_hook","class":"OCA\\Files_Versions\\Hooks","type":"::"},{"file":"/var/www/nextcloud/lib/private/Files/View.php","line":1284,"function":"emit","class":"OC_Hook","type":"::"},{"file":"/var/www/nextcloud/lib/private/Files/View.php","line":1212,"function":"runHooks","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud/lib/private/Files/View.php","line":349,"function":"basicOperation","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Directory.php","line":305,"function":"rmdir","class":"OC\\Files\\View","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Tree.php","line":179,"function":"delete","class":"OCA\\DAV\\Connector\\Sabre\\Directory","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":281,"function":"delete","class":"Sabre\\DAV\\Tree","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpDelete","class":"Sabre\\DAV\\CorePlugin","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":472,"function":"emit","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":253,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":321,"function":"start","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/lib/Server.php","line":360,"function":"exec","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/appinfo/v2/remote.php","line":35,"function":"exec","class":"OCA\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/remote.php","line":167,"args":["/var/www/nextcloud/apps/dav/appinfo/v2/remote.php"],"function":"require_once"}],"File":"/var/www/nextcloud/apps/files_versions/lib/Storage.php","Line":573,"message":"Unsupported operand types: int - string","exception":[],"CustomMessage":"Unsupported operand types: int - string"},"id":"632203e06c5d4"}

Additional info

2022-09-14.11-37-48.mp4

[come-nc]

@AndyXheli Can you look into files_version folder to see if there is a file missing the extension containing the timestamp?

[come-nc]

@AndyXheli Or if you can test: #34528 it should log an error when the name is not as expected and avoid type errors.

[AndyXheli]

After applying this patch heres the error log

{"reqId":"iqnECMJp20fT3kvlrUWM","level":3,"time":"2022-10-11T13:48:45+00:00","remoteAddr":"10.0.10.90","user":"axheli","app":"files_versions","method":"DELETE","url":"/remote.php/dav/files/axheli/IT%20Share/Software","message":"Version file Software has incorrect name format","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36","version":"25.0.0.15","data":{"app":"files_versions"},"id":"6345745274466"}

{"reqId":"dr3rrgXr2wv5oXHqNt1r","level":3,"time":"2022-10-11T13:48:44+00:00","remoteAddr":"10.0.10.90","user":"axheli","app":"files_versions","method":"DELETE","url":"/remote.php/dav/files/axheli/IT%20Share/Account%20Review","message":"Version file Account Review has incorrect name format","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36","version":"25.0.0.15","data":{"app":"files_versions"},"id":"63457452744f6"}

[come-nc]

@AndyXheli Thank you for testing.

So, do you have files named "Software" and "Account Review" in files_version folder? (if you do, can you use "ls -lh" to see how old they are and try to see if they are created by a current bug or were leftover of an old bug?)

[AndyXheli]

You're Welcome! Yes, i do have a folder called software and a folder called Account review

[AndyXheli]

What would you like me to do ?

[come-nc]

Those folders are in files_version?
Can you do ls -lh in there to see how old they are?
I am trying to understand if the bug is that these folders are in there, or that they do not get ignored correctly.

[AndyXheli]

Yes doing it right now :)

[AndyXheli]

Here you go

/var/data/axheli/files_versions/
drwxr-xr-x 2 www-data www-data 4.0K Apr 21 14:15 Applications
drwxr-xr-x 4 www-data www-data 4.0K Oct 11 13:55 Documents
drwxr-xr-x 6 www-data www-data 4.0K Apr 11 2022 'IT Share'
drwxr-xr-x 3 www-data www-data 4.0K Apr 21 14:15 Programs
drwxr-xr-x 2 www-data www-data 4.0K Oct 6 17:10 Talk

/var/data/axheli/files_versions/Documents/
drwxr-xr-x 2 www-data www-data 4.0K Oct 5 17:30 'Account Review'
drwxr-xr-x 2 www-data www-data 4.0K Oct 11 13:55 'Miscellaneous Documents'

/var/data/axheli/files_versions/IT Share/
drwxr-xr-x 2 www-data www-data 4.0K Apr 5 2022 'Account Review'
drwxr-xr-x 2 www-data www-data 4.0K Apr 5 2022 KeePass
drwxr-xr-x 2 www-data www-data 4.0K Apr 1 2022 'Remote Desktop Database'
drwxr-xr-x 2 www-data www-data 4.0K Apr 7 2022 Software

[AndyXheli]

Also when i go into these folders nothing inside.

I also have this in my config.php

'versions_retention_obligation' => 'auto,1',

not sure if it working

[come-nc]

Ok so I checked it is expected to have folders in files_versions. The problem is the cleanup code does not handle correctly getting called on a folder I think.