Skip to content

Search provider names in unified search hint do not respect localized language rules #25282

Closed

Description

Fits:

Screenshot_20210122_182232

Should be capitalised:

Screenshot_20210122_182352

It is not a translation issue. The search providers only have to provide a getName() method for a translated string. The provides all return it in capitalized fashion ("Apps", …). In core/src/views/UnifiedSearch.vue:47 they are hard-lowercased.

The best distinction is done by the translators however.

My suggestion would be to add another method (as another interface to avoid breakage) that would return a string to be used within a sentence. And fall back to getName(). The hard lowercasing in the view would be removed.

The alternative would be to only remove the forced lower cased, which would end up in a strange picture at least in English:

Screenshot_20210122_183238

@ChristophWurst @skjnldsv @jancborchardt what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions