-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(db): Prevent two connections for single node databases
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
- Loading branch information
1 parent
f0ec548
commit fe94824
Showing
2 changed files
with
109 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | ||
* SPDX-License-Identifier: AGPL-3.0-or-later | ||
*/ | ||
|
||
namespace Test\DB; | ||
|
||
use Doctrine\DBAL\Configuration; | ||
use Doctrine\DBAL\Driver; | ||
use Doctrine\DBAL\Driver\Connection as DriverConnection; | ||
use OC\DB\Adapter; | ||
use OC\DB\Connection; | ||
use Test\TestCase; | ||
|
||
/** | ||
* @group DB | ||
*/ | ||
class ConnectionTest extends TestCase { | ||
|
||
public function testSingleNodeConnectsToPrimaryOnly(): void { | ||
$connectionParams = [ | ||
'user' => 'test', | ||
'password' => 'topsecret', | ||
'host' => 'test', | ||
]; | ||
$adapter = $this->createMock(Adapter::class); | ||
$driver = $this->createMock(Driver::class); | ||
$configuration = $this->createMock(Configuration::class); | ||
$connection = $this->getMockBuilder(Connection::class) | ||
->onlyMethods(['connectTo']) | ||
->setConstructorArgs([ | ||
[ | ||
'adapter' => $adapter, | ||
'tablePrefix' => 'nctest', | ||
'primary' => $connectionParams, | ||
'replica' => [ | ||
$connectionParams, | ||
], | ||
], | ||
$driver, | ||
$configuration, | ||
]) | ||
->getMock(); | ||
$driverConnection = $this->createMock(DriverConnection::class); | ||
$connection->expects(self::once()) | ||
->method('connectTo') | ||
->with('primary') | ||
->willReturn($driverConnection); | ||
|
||
$connection->ensureConnectedToReplica(); | ||
$connection->ensureConnectedToPrimary(); | ||
$connection->ensureConnectedToReplica(); | ||
} | ||
|
||
public function testClusterConnectsToPrimaryAndReplica(): void { | ||
$connectionParamsPrimary = [ | ||
'user' => 'test', | ||
'password' => 'topsecret', | ||
'host' => 'testprimary', | ||
]; | ||
$connectionParamsReplica = [ | ||
'user' => 'test', | ||
'password' => 'topsecret', | ||
'host' => 'testreplica', | ||
]; | ||
$adapter = $this->createMock(Adapter::class); | ||
$driver = $this->createMock(Driver::class); | ||
$configuration = $this->createMock(Configuration::class); | ||
$connection = $this->getMockBuilder(Connection::class) | ||
->onlyMethods(['connectTo']) | ||
->setConstructorArgs([ | ||
[ | ||
'adapter' => $adapter, | ||
'tablePrefix' => 'nctest', | ||
'primary' => $connectionParamsPrimary, | ||
'replica' => [ | ||
$connectionParamsReplica, | ||
], | ||
], | ||
$driver, | ||
$configuration, | ||
]) | ||
->getMock(); | ||
$driverConnection = $this->createMock(DriverConnection::class); | ||
$connection->expects(self::exactly(2)) | ||
->method('connectTo') | ||
->willReturn($driverConnection); | ||
|
||
$connection->ensureConnectedToReplica(); | ||
$connection->ensureConnectedToPrimary(); | ||
$connection->ensureConnectedToReplica(); | ||
} | ||
|
||
} |