Merge pull request #45530 from nextcloud/jtr/fix-cron-memory-usage-le…

…vels fix(cron): Log excess memory usage at debug and info levels
nextcloud · Jun 12, 2024 · a11262b · a11262b
2 parents b3e4270 + ecef392
commit a11262b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/cron.php b/cron.php
@@ -182,10 +182,10 @@
 				);
 			}
 
-			if ($memoryAfter - $memoryBefore > 10_000_000) {
-				$logger->warning('Used memory grew by more than 10 MB when executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryAfter). ' (before: ' . Util::humanFileSize($memoryBefore) . ')', ['app' => 'cron']);
+			if ($memoryAfter - $memoryBefore > 50_000_000) {
+				$logger->warning('Used memory grew by more than 50 MB when executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryAfter). ' (before: ' . Util::humanFileSize($memoryBefore) . ')', ['app' => 'cron']);
 			}
-			if ($memoryPeakAfter > 300_000_000) {
+			if ($memoryPeakAfter > 300_000_000 && $memoryPeakBefore <= 300_000_000) {
 				$logger->warning('Cron job used more than 300 MB of ram after executing job ' . $jobDetails . ': ' . Util::humanFileSize($memoryPeakAfter) . ' (before: ' . Util::humanFileSize($memoryPeakBefore) . ')', ['app' => 'cron']);
 			}