Skip to content

Commit

Permalink
Adjust acceptance test selectors
Browse files Browse the repository at this point in the history
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
  • Loading branch information
PVince81 committed Aug 24, 2022
1 parent 9010834 commit 9905889
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tests/acceptance/features/bootstrap/AppNavigationContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static function appNavigation() {
* @return Locator
*/
public static function appNavigationSectionItemFor($sectionText) {
return Locator::forThe()->xpath("//li/a[normalize-space() = '$sectionText']/..")->
return Locator::forThe()->xpath("//li/div[contains(normalize-space(), '$sectionText')]/..")->
descendantOf(self::appNavigation())->
describedAs($sectionText . " section item in App Navigation");
}
Expand All @@ -49,7 +49,7 @@ public static function appNavigationSectionItemFor($sectionText) {
* @return Locator
*/
public static function appNavigationSectionItemInFor($caption, $sectionText) {
return Locator::forThe()->xpath("//li[normalize-space() = '$caption']/following-sibling::li/a[normalize-space() = '$sectionText']/..")->
return Locator::forThe()->xpath("//li[normalize-space() = '$caption']/following-sibling::li/div[contains(normalize-space(), '$sectionText'])/..")->
descendantOf(self::appNavigation())->
describedAs($sectionText . " section item of the $caption group in App Navigation");
}
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/bootstrap/FilesAppContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public static function favoriteActionInFileDetailsInDetailsView() {
* @return Locator
*/
public static function notFavoritedStateIconInFileDetailsInDetailsView() {
return Locator::forThe()->css(".star--star")->
return Locator::forThe()->css(".star-outline-icon")->
descendantOf(self::favoriteActionInFileDetailsInDetailsView())->
describedAs("Not favorited state icon in file details in details view in Files app");
}
Expand All @@ -125,7 +125,7 @@ public static function notFavoritedStateIconInFileDetailsInDetailsView() {
* @return Locator
*/
public static function favoritedStateIconInFileDetailsInDetailsView() {
return Locator::forThe()->css(".star--starred")->
return Locator::forThe()->css(".star-icon")->
descendantOf(self::favoriteActionInFileDetailsInDetailsView())->
describedAs("Favorited state icon in file details in details view in Files app");
}
Expand Down

0 comments on commit 9905889

Please sign in to comment.