fix(files_sharing): Resolve race condition blocking link share requests

Fixed a race condition in the frontend that prevented share link creation requests
from being sent to the backend. Instead of communicating with the server,
the share links were incorrectly added to the frontend list, and a new menu
to create another link appeared.

This fix ensures the correct sequence of actions, allowing share links to be
properly created and synchronized with the backend.

Signed-off-by: nfebe <fenn25.fn@gmail.com>

apps/files_sharing/src/components/SharingEntryLink.vue

@@ -298,6 +298,7 @@ export default {
 			copySuccess: true,
 			copied: false,
 			defaultExpirationDateEnabled: false,
+			shareReviewComplete: false,
 
 			// Are we waiting for password/expiration date
 			pending: false,
@@ -492,7 +493,11 @@ export default {
 		},
 
 		shareRequiresReview() {
-			return this.defaultExpirationDateEnabled || this.config.enableLinkPasswordByDefault
+			this.logger.info('Share requires review?', this.shareReviewComplete)
+			if (this.shareReviewComplete) {
+				return false
+			}
+			return (this.defaultExpirationDateEnabled || this.config.enableLinkPasswordByDefault) && !this.isPendingShare
 		},
 
 		sharePolicyHasRequiredProperties() {
@@ -596,8 +601,8 @@ export default {
 		},
 	},
 	mounted() {
+		this.defaultExpirationDateEnabled = this.config.defaultExpirationDate instanceof Date
 		if (this.share) {
-			this.defaultExpirationDateEnabled = this.config.defaultExpirationDate instanceof Date
 			this.share.expireDate = this.defaultExpirationDateEnabled ? this.formatDateToString(this.config.defaultExpirationDate) : ''
 		}
 	},
@@ -629,8 +634,7 @@ export default {
 			if ((this.sharePolicyHasRequiredProperties && this.requiredPropertiesMissing) || this.shareRequiresReview) {
 				this.pending = true
 				this.shareCreationComplete = false
-
-				this.logger.info('Share policy requires mandated properties (password)...')
+				this.logger.info('Share policy requires a review or has mandated properties (password, expirationDate)...')
 
 				// ELSE, show the pending popovermenu
 				// if password default or enforced, pre-fill with random one
@@ -648,6 +652,7 @@ export default {
 				// freshly created share component
 				this.open = false
 				this.pending = false
+				this.shareReviewComplete = true
 				component.open = true
 
 				// Nothing is enforced, creating share directly
@@ -678,6 +683,7 @@ export default {
 				const share = new Share(shareDefaults)
 				await this.pushNewLinkShare(share)
 				this.shareCreationComplete = true
+				this.shareReviewComplete = false
 			}
 		},