Merge pull request #36740 from nextcloud/enh/a11y-contact-img-alt

Add avatar contact img description
nextcloud · Mar 3, 2023 · 6c79621 · 6c79621
2 parents c5da4b8 + 9d904b1
commit 6c79621
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 8 deletions.
diff --git a/core/src/OC/contactsmenu.js b/core/src/OC/contactsmenu.js
@@ -55,6 +55,11 @@ const Contact = Model.extend({
 		} else {
 			this.set('hasManyActions', true)
 		}
+
+		const fullName = this.get('fullName')
+		if (this.get('avatar') && fullName) {
+			this.set('avatarLabel', t('core', 'Avatar of {fullName}', { fullName }))
+		}
 	}
 })
 

diff --git a/core/src/OC/contactsmenu/contact.handlebars b/core/src/OC/contactsmenu/contact.handlebars
@@ -2,11 +2,11 @@
 	{{#if contact.profileUrl}}
 		{{#if contact.profileTitle}}
 			<a class="profile-link--avatar" href="{{contact.profileUrl}}">
-				<img src="{{contact.avatar}}&size=32" class="avatar" srcset="{{contact.avatar}}&size=32 1x, {{contact.avatar}}&size=64 2x, {{contact.avatar}}&size=128 4x" alt="">
+				<img src="{{contact.avatar}}&size=32" class="avatar" srcset="{{contact.avatar}}&size=32 1x, {{contact.avatar}}&size=64 2x, {{contact.avatar}}&size=128 4x" alt="{{contact.avatarLabel}}">
 			</a>
 		{{/if}}
 	{{else}}
-		<img src="{{contact.avatar}}&size=32" class="avatar" srcset="{{contact.avatar}}&size=32 1x, {{contact.avatar}}&size=64 2x, {{contact.avatar}}&size=128 4x" alt="">
+		<img src="{{contact.avatar}}&size=32" class="avatar" srcset="{{contact.avatar}}&size=32 1x, {{contact.avatar}}&size=64 2x, {{contact.avatar}}&size=128 4x" alt="{{contact.avatarLabel}}">
 	{{/if}}
 {{else}}
 	{{#if contact.profileUrl}}

diff --git a/dist/core-login.js b/dist/core-login.js
diff --git a/dist/core-login.js.map b/dist/core-login.js.map
diff --git a/dist/core-main.js b/dist/core-main.js
diff --git a/dist/core-main.js.map b/dist/core-main.js.map