Merge pull request #33030 from nextcloud/backport/32968/stable23

[stable23] Do not display the buffer_size info if the size is already set to a c…

apps/settings/lib/Controller/CheckSetupController.php

@@ -525,7 +525,11 @@ protected function getOpcacheSetupRecommendations(): array {
 
 			if (
 				empty($status['interned_strings_usage']['free_memory']) ||
-				($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9)
+				(
+					($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) &&
+					// Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size
+					($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4)
+				)
 			) {
 				$recommendations[] = $this->l10n->t('The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply <code>opcache.interned_strings_buffer</code> to your PHP configuration with a value higher than <code>%s</code>.', [($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?: 'currently')]);
 			}