fix truncated circleId returned from Share API

nextcloud · Feb 23, 2024 · 311d1d2 · 311d1d2
1 parent fa773ec
commit 311d1d2
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -310,10 +310,11 @@ protected function formatShare(IShare $share, Node $recipientNode = null): array
 
 			$shareWithStart = ($hasCircleId ? strrpos($share->getSharedWith(), '[') + 1 : 0);
 			$shareWithLength = ($hasCircleId ? -1 : strpos($share->getSharedWith(), ' '));
-			if (is_bool($shareWithLength)) {
-				$shareWithLength = -1;
+			if ($shareWithLength === false) {
+				$result['share_with'] = substr($share->getSharedWith(), $shareWithStart);
+			} else {
+				$result['share_with'] = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
 			}
-			$result['share_with'] = substr($share->getSharedWith(), $shareWithStart, $shareWithLength);
 		} elseif ($share->getShareType() === IShare::TYPE_ROOM) {
 			$result['share_with'] = $share->getSharedWith();
 			$result['share_with_displayname'] = '';