Merge pull request #45860 from nextcloud/fix/files-handle-failed-state

fix(files): Bring back handling of failed files

apps/files/src/components/FileEntry.vue

@@ -16,7 +16,7 @@
 		class="files-list__row"
 		v-on="rowListeners">
 		<!-- Failed indicator -->
-		<span v-if="source.attributes.failed" class="files-list__row--failed" />
+		<span v-if="isFailedSource" class="files-list__row--failed" />
 
 		<!-- Checkbox -->
 		<FileEntryCheckbox :fileid="fileid"

apps/files/src/components/FileEntry/FileEntryActions.vue

@@ -90,9 +90,9 @@ import NcActionSeparator from '@nextcloud/vue/dist/Components/NcActionSeparator.
 import NcIconSvgWrapper from '@nextcloud/vue/dist/Components/NcIconSvgWrapper.js'
 import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
 import ArrowLeftIcon from 'vue-material-design-icons/ArrowLeft.vue'
+import CustomElementRender from '../CustomElementRender.vue'
 
 import { useNavigation } from '../../composables/useNavigation'
-import CustomElementRender from '../CustomElementRender.vue'
 import logger from '../../logger.js'
 
 // The registered actions list
@@ -160,7 +160,7 @@ export default defineComponent({
 
 		// Sorted actions that are enabled for this node
 		enabledActions() {
-			if (this.source.attributes.failed) {
+			if (this.source.status === NodeStatus.FAILED) {
 				return []
 			}
 

apps/files/src/components/FileEntry/FileEntryName.vue

@@ -126,7 +126,7 @@ export default defineComponent({
 		},
 
 		linkTo() {
-			if (this.source.attributes.failed) {
+			if (this.source.status === NodeStatus.FAILED) {
 				return {
 					is: 'span',
 					params: {

apps/files/src/components/FileEntryGrid.vue

@@ -17,7 +17,7 @@
 		@dragend="onDragEnd"
 		@drop="onDrop">
 		<!-- Failed indicator -->
-		<span v-if="source.attributes.failed" class="files-list__row--failed" />
+		<span v-if="isFailedSource" class="files-list__row--failed" />
 
 		<!-- Checkbox -->
 		<FileEntryCheckbox :fileid="fileid"

apps/files/src/components/FileEntryMixin.ts

@@ -50,14 +50,14 @@ export default defineComponent({
 	computed: {
 		currentDir() {
 			// Remove any trailing slash but leave root slash
-			return (this.$route?.query?.dir?.toString() || '/').replace(/^(.+)\/$/, '$1')
+			return (this.$route.query?.dir?.toString() || '/').replace(/^(.+)\/$/, '$1')
 		},
 		currentFileId() {
 			return this.$route.params?.fileid || this.$route.query?.fileid || null
 		},
 
 		fileid() {
-			return this.source?.fileid
+			return this.source.fileid ?? 0
 		},
 		uniqueId() {
 			return hashCode(this.source.source)
@@ -102,6 +102,13 @@ export default defineComponent({
 			return String(this.fileid) === String(this.currentFileId)
 		},
 
+		/**
+		 * Check if the source is in a failed state after an API request
+		 */
+		isFailedSource() {
+			return this.source.status === NodeStatus.FAILED
+		},
+
 		canDrag() {
 			if (this.isRenaming) {
 				return false

apps/files/src/utils/hashUtils.ts

@@ -3,6 +3,11 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
+/**
+ * Simple non-secure hashing function similar to Java's `hashCode`
+ * @param str The string to hash
+ * @return {number} a non secure hash of the string
+ */
 export const hashCode = function(str: string): number {
 	let hash = 0
 	for (let i = 0; i < str.length; i++) {