comments

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

lib/private/Blurhash/Listener/GenerateBlurhashMetadata.php

@@ -52,7 +52,7 @@ class GenerateBlurhashMetadata implements IEventListener {
 	private const COMPONENTS_Y = 3;
 
 	public function __construct(
-		private IPreview $preview
+		private IPreview $preview,
 	) {
 	}
 
@@ -72,19 +72,20 @@ public function handle(Event $event): void {
 			return;
 		}
 
+		// too heavy to run on the live thread, request a rerun as a background job
 		if ($event instanceof MetadataLiveEvent) {
 			$event->requestBackgroundJob();
-
 			return;
 		}
 
 		$image = false;
 		try {
+			// using preview image to generate the blurhash
 			$preview = $this->preview->getPreview($file, 256, 256);
 			$image = imagecreatefromstring($preview->getContent());
 		} catch (NotFoundException $e) {
 			// https://github.com/nextcloud/server/blob/9d70fd3e64b60a316a03fb2b237891380c310c58/lib/private/legacy/OC_Image.php#L668
-			// The preview system can fail on huge picture, in that case we use our own resize image.
+			// The preview system can fail on huge picture, in that case we use our own image resizer.
 			if (str_starts_with($file->getMimetype(), 'image/')) {
 				$image = $this->resizedImageFromFile($file);
 			}
@@ -124,11 +125,7 @@ private function resizedImageFromFile(File $file): GdImage|false {
 		}
 
 		$newImage = imagescale($image, $newX, $newY);
-		if (false !== $newImage) {
-			$image = $newImage;
-		}
-
-		return $image;
+		return ($newImage !== false) ? $newImage : $image;
 	}
 
 	/**