fix: return type doc block added as per psalm

Signed-off-by: yemkareems <yemkareems@gmail.com>
nextcloud · Jul 4, 2024 · 070ba4f · 070ba4f
1 parent 839b5d0
commit 070ba4f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/lib/private/AllConfig.php b/lib/private/AllConfig.php
@@ -497,7 +497,7 @@ public function getUsersForUserValue($appName, $key, $value) {
 	 * @param int|null $limit how many users to fetch
 	 * @param int $offset from which offset to fetch
 	 * @param string $search search users based on search params
-	 * @return array<string, string> list of user IDs
+	 * @return list<string> list of user IDs
 	 */
 	public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array {
 		// TODO - FIXME
@@ -513,22 +513,23 @@ public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string
 			);
 		if($search !== '') {
 			$query->leftJoin('u', 'preferences', 'p1', $query->expr()->andX(
-					$query->expr()->eq('p1.userid', 'uid'),
-					$query->expr()->eq('p1.appid', $query->expr()->literal('settings')),
-					$query->expr()->eq('p1.configkey', $query->expr()->literal('email')))
-				)
+				$query->expr()->eq('p1.userid', 'uid'),
+				$query->expr()->eq('p1.appid', $query->expr()->literal('settings')),
+				$query->expr()->eq('p1.configkey', $query->expr()->literal('email')))
+			)
 				// sqlite doesn't like re-using a single named parameter here
 				->where($query->expr()->iLike('uid', $query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($search) . '%')))
 				->orWhere($query->expr()->iLike('displayname', $query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($search) . '%')))
 				->orWhere($query->expr()->iLike('p1.configvalue', $query->createPositionalParameter('%' . $this->connection->escapeLikeParameter($search) . '%'))
-			);
+				);
 		}
 		$query->orderBy($query->func()->lower('p.configvalue'), 'DESC')
 			->addOrderBy('uid_lower', 'ASC')
 			->setFirstResult($offset)
 			->setMaxResults($limit);
 
 		$result = $query->executeQuery();
+		/** @var list<string> $uids */
 		$uids = $result->fetchAll(\PDO::FETCH_COLUMN);
 		$result->closeCursor();
 

diff --git a/lib/public/IConfig.php b/lib/public/IConfig.php
@@ -256,7 +256,7 @@ public function getUsersForUserValue($appName, $key, $value);
 	 * @param int|null $limit how many records to fetch
 	 * @param int $offset from which offset to fetch
 	 * @param string $search search users based on search params
-	 * @return array<string, string> list of user IDs
+	 * @return list<string> list of user IDs
 	 * @since 30.0.0
 	 */
 	public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array;