Skip to content

Move to webpack bundling #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 16, 2019
Merged

Move to webpack bundling #540

merged 17 commits into from
Jul 16, 2019

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 4, 2019

Part 1 of #541

  • Setup webpack
  • Convert code style
  • Move out url and l10n helper
  • stylelint
  • krankerl for packaging
  • drone build frontend code
  • Remove unused documentList jquery widget and simplify loading indicator

0f058e3 and 80736c8 are just code style conversion without changing any logic change, the rest was split in small commits, so it is a bit easier to review.

@juliusknorr juliusknorr added the 2. developing Work in progress label Jul 4, 2019
@juliusknorr juliusknorr added this to the 3.3.0 milestone Jul 4, 2019
@juliusknorr juliusknorr mentioned this pull request Jul 4, 2019
7 tasks
@juliusknorr juliusknorr modified the milestones: 3.3.0, 3.4 Jul 5, 2019
@juliusknorr juliusknorr added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Jul 5, 2019
@juliusknorr juliusknorr requested review from rullzer and skjnldsv July 5, 2019 11:11
OCA: true,
'$': true,
'_': true,
Vue: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have any vue files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, as I wanted to do the migration in smaller chunks 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, so let's leave this I guess then :)

Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one slight thing that's more a nitpick.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff lets do it!

juliusknorr and others added 16 commits July 16, 2019 07:39
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Co-Authored-By: Gary Kim <gary@garykim.dev>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added 4. to release Ready to release, can be waiting for the tests to finish and removed 3. to review Ready to be reviewed labels Jul 16, 2019
@juliusknorr juliusknorr merged commit 5c306b1 into master Jul 16, 2019
@juliusknorr juliusknorr deleted the webpack branch July 16, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to release, can be waiting for the tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants