fix: Emit files:node:updated event on UI_Save#5293
Merged
silverkszlo merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
Member
|
I'm unsure if this only catches the manual save through the menu bar button. For autosave this could be interesting as well, but from the post message documentation i do not see any hint that there is such a message. There is Action_Save_Resp but I'm unsure if that will get triggered. Nothing blocking, but something to check and file with collabora as possible follow up I'd say. |
juliusknorr
approved these changes
Jan 27, 2026
elzody
force-pushed
the
fix/emit-event-on-file-save
branch
from
5afe54f to
520f972
Compare
silverkszlo
force-pushed
the
fix/emit-event-on-file-save
branch
from
520f972 to
0c4394a
Compare
elzody
force-pushed
the
fix/emit-event-on-file-save
branch
from
0c4394a to
33b596a
Compare
elzody
approved these changes
Jan 29, 2026
Collaborator
|
The failing tests should hopefully pass once #5312 is merged. |
elzody
force-pushed
the
fix/emit-event-on-file-save
branch
from
33b596a to
1df9dd7
Compare
silverkszlo
force-pushed
the
fix/emit-event-on-file-save
branch
from
1df9dd7 to
661dae6
Compare
Handle UI_Save post message to update file info and emit files:node:updated event, allowing other components like the versions sidebar to react to document saves. Signed-off-by: silver <s.szmajduch@posteo.de>
silverkszlo
force-pushed
the
fix/emit-event-on-file-save
branch
from
661dae6 to
8a2b0e3
Compare
Contributor
Author
|
Failing cypress tests seem unrelated, so I'm merging this |
Collaborator
|
/backport to stable33 |
Collaborator
|
/backport to stable32 |
Collaborator
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle
UI_Savepost message to update file info and emitfiles:node:updatedevent, allowing other components like the versions sidebar to react to document saves.Checklist