Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use product name from collabora capabilities #477

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Use product name from collabora capabilities #477

merged 1 commit into from
Apr 17, 2019

Conversation

juliusknorr
Copy link
Member

No description provided.

@juliusknorr
Use product name from collabora capabilities
455e1f2 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added enhancement New feature or request 3. to review Ready to be reviewed labels Apr 16, 2019
@juliusknorr juliusknorr added this to the 3.3.0 milestone Apr 16, 2019
@juliusknorr juliusknorr requested a review from rullzer April 16, 2019 14:46
rullzer
rullzer approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliusknorr
Copy link
Member Author

juliusknorr commented Apr 16, 2019 •
edited
Loading

cc @tobiasKaminsky @marinofaggiana On android the 3-dots menu shows "Open with collabora" which should probably also use the product name from the capabilities. Not sure about iOS, but everywhere you use "Collabora Online" you should respect the capability value productName if present.

   <richdocuments>
    ...
    <productName>Collabora Online</productName>
   </richdocuments>

@juliusknorr juliusknorr merged commit f269b91 into master Apr 17, 2019
@tobiasKaminsky
Copy link
Member

Do you have an idea how to do this on client side without checking for version or have an ever-lasting backward compatiblity check in it?

@juliusknorr
Copy link
Member Author

Hm, no idea unfortunately. I the app provides a proper fallback value of "Collabora Online" but that only helps for richdocuments >= 3.3.0

I think just supporting the most recent app version should be fine, since we do not support older app versions in general, right @rullzer ?

@juliusknorr juliusknorr deleted the bugfix/noid/product-name branch April 17, 2019 13:09
@tobiasKaminsky
Copy link
Member

Library: nextcloud/android-library#291
App: nextcloud/android#3971

@tobiasKaminsky
Copy link
Member

@marinofaggiana to stay consistenst across mobile

rotdrop pushed a commit to rotdrop/nextcloud-richdocuments that referenced this pull request Nov 24, 2023
@marcelklehr
Merge pull request nextcloud#477 from nextcloud/dependabot/npm_and_ya…
3a421dd 
…rn/vue-2.7.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review Ready to be reviewed enhancement New feature or request
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @tobiasKaminsky @rullzer